[PERFSCALE-3427] Public VLAN improvements #549

rsevilla87 · 2024-09-17T22:49:06Z

Adding some improvements to deploy in public VLANs in bm. Also updating the docs accordigly

rsevilla87 · 2024-09-18T13:31:18Z

ansible/roles/create-inventory/tasks/main.yml

akrzos · 2024-09-18T19:35:27Z

ansible/roles/create-inventory/templates/inventory-bm.j2

+{% if lab_name == "scalelab" %}
+base_dns_name=rdu2.scalelab.redhat.com
+{% elif lab_name == "performancelab" %}
+base_dns_name=rdu3.labs.perfscale.redhat.com
+{% else %}
+base_dns_name=example.com
+{% endif %}


We will have to carefully review this as base_dns_name today is a var within this file and not an inventory var. Inventory vars must be referenced from the context of a host vs just being a var. We should be able to switch it just need to think through all of the potential cases this would touch.

I had to include it as an inventory lab since this variable its referenced in the create-ai-cluster role, which is executed in the deploy stage. What do you suggest?

I see, but it's not actually referenced as a host var, the difference would be something like such:

Inventory:

[all:vars] allocation_node_count=15 supermicro_nodes=False base_dns_name=bar [bastion] e38-h01-...

Playbook:

- name: Test hosts: bastion gather_facts: false vars: base_dns_name: foo tasks: - name: debug task debug: msg: "{{ item }}" loop: - "{{ base_dns_name }}" - "{{ hostvars[inventory_hostname].base_dns_name }}"

Output:

PLAY [Test] ********************************************************************************************************************************************************************************** TASK [debug task] **************************************************************************************************************************************************************************** Friday 20 September 2024 09:33:28 -0400 (0:00:00.005) 0:00:00.005 ****** ok: [e38-h01-...] => (item=foo) => { "msg": "foo" } ok: [e38-h01-...] => (item=bar) => { "msg": "bar" } PLAY RECAP *********************************************************************************************************************************************************************************** e38-h01-...

So if we want the automatic configuration of the base_dns_name with the determination to be in "step1" the create-inventory we would need to migrate all references of base_dns_name (aside from create-inventory templating the inventory) to {{ hostvars[inventory_hostname].base_dns_name }} Let me know if this makes sense because it would apply to cluster_name as well.

So my suggestion would be that base_dns_name and cluster_name be "step1 one vars" in all.yml meaning they just get rendered into the inventory file and all future usage of them is actually through a hostvar. Folks would have to keep in mind if they intend on changing the cluster_name or base_dns_name they would have to start from the first step which is creating inventory.

akrzos · 2024-09-18T19:37:11Z

docs/deploy-bm-performancelab.md

+
+- `public_vlan`: Enable this variable **before creating the inventory**, to let jetlag to auto-configure the interface number (`controlplane_network_interface_idx`) to the last of the available NICs of the ocpinventory.json file, when this variable is configured, `base_dns_name` is set to `rdu2.scalelab.redhat.com` in the inventory file.
+- `cluster_name`: Should be configured to the public VLAN name. i.e: `vlan600`, check the public VLANs allocation info in the [scalelab's wiki](https://wiki.rdu3.labs.perfscale.redhat.com/vlans/)
+- `controlplane_network`, `network_prefix` and `gateway` also need to be configured to its corresponding values.


Maybe we could get quads to expose these values as json too, and add automation to automatically grab the typical values.

yeah, that would be ideal, but as far as I know, quads only expose VLAN allocation at https://wiki.rdu3.labs.perfscale.redhat.com/vlans/, I'll ask the quads team just in case

done, I included some quads API magic to autogen most of the variables we need to deploy in the public VLAN, seems like quads has an older version in the performancelab though which and the API endpoint is not available, currently investigating that

Added the performancelab working code, not very fancy... (actually very ugly), but as long as quads runs an older version in the performancelab I haven't found another alternatyve

akrzos · 2024-09-18T19:41:51Z

docs/deploy-bm-scalelab.md

+    - [Disconnected and ipv6 vars](#disconnected-and-ipv6-vars)
+  - [Review vars `all.yml`](#review-vars-allyml)
+  - [Run playbooks](#run-playbooks)
+  - [Monitor install and interact with cluster](#monitor-install-and-interact-with-cluster)


🥇 Just wanted to point out I really appreciate the inclusion of documentation with your pull request, this will be super helpful for when other folks want to deploy a public vlan cluster.

akrzos · 2024-09-18T19:51:18Z

ansible/vars/all.sample.yml

@@ -11,6 +11,9 @@ lab_cloud:
 # Either bm or rwn or sno
 cluster_type:

+# Applies to both bm/rwn clusters
+cluster_name: bm


I think we should adjust the default for cluster_name to mno since it will only effect multi-node clusters. I also believe we should remove it from here since we want to bubble this up to the all.yml. WDYT?

docs/deploy-bm-performancelab.md

rsevilla87 · 2024-09-19T23:46:36Z

ansible/roles/create-inventory/templates/inventory-bm.j2

@@ -1,6 +1,16 @@
 [all:vars]
 allocation_node_count={{ ocpinventory.json.nodes | length }}
 supermicro_nodes={{ has_supermicro | bool }}
+cluster_name={{ cluster_name }}


cluster_name is required here as it needs to be configured by the create-inventory playbook when using a publi VLAN

I think we should put this inside the public_vlan conditional.

ansible/vars/lab.yml

ansible/roles/create-inventory/tasks/main.yml

docs/deploy-bm-performancelab.md

docs/deploy-bm-scalelab.md

ansible/roles/create-inventory/tasks/main.yml

dbutenhof

For the record, I'm still uncomfortable with the grep -B7. The risk here is that something will eventually break these assumptions before before the performancelab QUADS is upgraded and "someone" gets around to removing your performancelab workaround.

I don't see a practical alternative; so even though I dislike leaving that sort of tech debt, I'm approving.

akrzos · 2024-09-30T15:05:14Z

@radez Did you have any feedback to this PR? I know you have been working with public vlan SNO clusters.

ansible/vars/all.sample.yml

radez · 2024-09-30T18:13:26Z

docs/deploy-bm-performancelab.md

@@ -324,13 +344,22 @@ lab_cloud: cloud99
 # Either bm or rwn or sno
 cluster_type: bm

+# Applies to both bm/rwn clusters
+cluster_name: mno


This should also stay bm until bm is replaced with mno

radez · 2024-09-30T18:13:56Z

docs/deploy-bm-scalelab.md

@@ -321,9 +341,27 @@ lab_cloud: cloud99
 # Either bm or rwn or sno
 cluster_type: bm

+# Applies to both bm/rwn clusters
+cluster_name: mno


Another bm/mno

Signed-off-by: Raul Sevilla <[email protected]>

rsevilla87 changed the title ~~Public VLAN improvements~~ [PERFSCALE-3427] Public VLAN improvements Sep 18, 2024

akrzos requested review from dbutenhof and akrzos September 18, 2024 19:08

akrzos requested changes Sep 18, 2024

View reviewed changes

rsevilla87 force-pushed the public-vlan branch from 4f63389 to 8c8724f Compare September 19, 2024 11:30

dbutenhof reviewed Sep 19, 2024

View reviewed changes

docs/deploy-bm-performancelab.md Outdated Show resolved Hide resolved

rsevilla87 commented Sep 19, 2024

View reviewed changes

ansible/vars/lab.yml Show resolved Hide resolved

rsevilla87 force-pushed the public-vlan branch from 546312f to af6dbc2 Compare September 19, 2024 23:50

akrzos requested a review from radez September 20, 2024 18:47

rsevilla87 force-pushed the public-vlan branch from bb7a0f2 to 2f19480 Compare September 23, 2024 10:46

dbutenhof requested changes Sep 23, 2024

View reviewed changes

ansible/roles/create-inventory/tasks/main.yml Outdated Show resolved Hide resolved

dbutenhof reviewed Sep 24, 2024

View reviewed changes

dbutenhof approved these changes Sep 24, 2024

View reviewed changes

radez requested changes Sep 30, 2024

View reviewed changes

rsevilla87 added 10 commits October 2, 2024 15:57

Public VLAN improvements

8b528ed

Signed-off-by: Raul Sevilla <[email protected]>

Fix controlplane_network_interface_idx expression

669a944

Signed-off-by: Raul Sevilla <[email protected]>

Discover VLAN settings from quads APi

6f7bd66

Signed-off-by: Raul Sevilla <[email protected]>

Consume quads API

ee0aba6

Signed-off-by: Raul Sevilla <[email protected]>

Get VLAN information from performancelab

5e2acb2

Signed-off-by: Raul Sevilla <[email protected]>

Add base_dns_name to all.yml and take it out from defaults

e485b44

Signed-off-by: Raul Sevilla <[email protected]>

Addressing comments

9ec6f25

Signed-off-by: Raul Sevilla <[email protected]>

Addressing documentation suggestions

65473b6

Signed-off-by: Raul Sevilla <[email protected]>

Conditional cluster_name

2def130

Signed-off-by: Raul Sevilla <[email protected]>

Address comments

255f508

Signed-off-by: Raul Sevilla <[email protected]>

rsevilla87 force-pushed the public-vlan branch from e979594 to 255f508 Compare October 2, 2024 14:05

akrzos approved these changes Oct 2, 2024

View reviewed changes

akrzos merged commit 8aee2a8 into redhat-performance:main Oct 2, 2024

rsevilla87 deleted the public-vlan branch October 2, 2024 15:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PERFSCALE-3427] Public VLAN improvements #549

[PERFSCALE-3427] Public VLAN improvements #549

rsevilla87 commented Sep 17, 2024

rsevilla87 commented Sep 18, 2024

akrzos Sep 18, 2024

rsevilla87 Sep 20, 2024

akrzos Sep 20, 2024

akrzos Sep 20, 2024

akrzos Sep 18, 2024

rsevilla87 Sep 19, 2024

rsevilla87 Sep 20, 2024

rsevilla87 Sep 23, 2024

akrzos Sep 18, 2024

akrzos Sep 18, 2024

rsevilla87 Sep 19, 2024

rsevilla87 Sep 19, 2024 •

edited

Loading

akrzos Sep 30, 2024

rsevilla87 Oct 2, 2024

dbutenhof left a comment

akrzos commented Sep 30, 2024

radez Sep 30, 2024

radez Sep 30, 2024

[PERFSCALE-3427] Public VLAN improvements #549

[PERFSCALE-3427] Public VLAN improvements #549

Conversation

rsevilla87 commented Sep 17, 2024

rsevilla87 commented Sep 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rsevilla87 Sep 19, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dbutenhof left a comment

Choose a reason for hiding this comment

akrzos commented Sep 30, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rsevilla87 Sep 19, 2024 •

edited

Loading