Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trimmed some extra fields off a task to reduce complexity #545

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Trimmed some extra fields off a task to reduce complexity #545

merged 1 commit into from
Sep 5, 2024

Conversation

akrzos
Copy link
Member

@akrzos akrzos commented Sep 4, 2024

No description provided.

@akrzos akrzos requested a review from radez September 4, 2024 19:37
@akrzos akrzos marked this pull request as ready for review September 4, 2024 19:37
@akrzos akrzos requested a review from dbutenhof September 4, 2024 19:37
dbutenhof
dbutenhof approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The only part that's hard to visually verify is dropping the register ... but I can easily believe it wasn't used.

@akrzos
Copy link
Member Author

akrzos commented Sep 4, 2024

Looks good. The only part that's hard to visually verify is dropping the register ... but I can easily believe it wasn't used.

Yeah I happened to notice that the var is registers syncfile is not in use anywhere, not sure how or why it was originally added.

@akrzos akrzos merged commit 9f6962d into redhat-performance:main Sep 5, 2024
@akrzos akrzos deleted the clean_sync_task branch September 5, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbutenhof dbutenhof dbutenhof approved these changes

@radez radez Awaiting requested review from radez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akrzos @dbutenhof