Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding trailing backslash rule #899

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

aireilly
Copy link
Member

@aireilly aireilly commented Oct 29, 2024

Trailing backslashes in codeblocks break the openshift-docs Asciibinder build. Backslashes are only a problem in asciibinder when they come just before the end of a codeblock.

@aireilly
Copy link
Member Author

Fixes #857

Copy link

github-actions bot commented Oct 29, 2024

Deploy PR Preview failed.

@aireilly aireilly requested a review from apinnick October 29, 2024 15:47
@aireilly aireilly force-pushed the trailing-backslash branch 3 times, most recently from 792bc2a to 347655f Compare November 6, 2024 20:05
@aireilly aireilly force-pushed the trailing-backslash branch 3 times, most recently from 28c017a to ab8367f Compare January 27, 2025 14:03
@aireilly aireilly requested a review from apinnick January 27, 2025 14:04
Copy link
Collaborator

@apinnick apinnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just had a question about the red symbol at the end of the yml file but doesn't block this PR.

@aireilly aireilly merged commit 38834af into redhat-documentation:main Jan 29, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants