-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error or warning for GitHub links #828
Comments
Great idea! Do you want to put this in? Something like this would work: ---
extends: substitution
ignorecase: false
level: error
link: https://redhat-documentation.github.io/vale-at-red-hat/docs/main/reference-guide/github/
message: "%s"
scope: raw
swap:
# Start each error message with "Do not use ..."
# Error messages must be single quoted.
'https://github.com/': 'Do not include links to GitHub in source.' |
Feel free to assign me to this issue if that helps. |
Note - repos inside the OpenShift org are Ok. |
I think "owned and maintained by Red Hat" would cover that. Or did you want that URL in the 'valid' list? |
I think we need clarification from @kalexand-rh maybe. Are all GitHub links forbidden? Or are GitHub links from inside the OpenShift organization allowed? |
OpenShift does not allow links to GitHub repositories unless they are in auto-generated API references. Other projects require project management approval. The RHSSG also does not allow links to GitHub. I think it would be a good idea to add a rule to detect GitHub links.
The text was updated successfully, but these errors were encountered: