changed replace to replaceAll on schema #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: msivasubramaniaan <[email protected]>
4 tasks
datho7561
requested changes
Feb 24, 2025
There was a problem hiding this comment.
I think the title here is misleading. You aren't updating eslint. What you're updating is the JavaScript version that the TypeScript compiler will let you use methods from and the JavaScript version of the code that the TypeScript compiler generates. This change is needed because replaceAll was introduced in the ECMAScript 2021 specification. (es6 was released in 2015, before the versions were labelled by the year they were released).
I think the title of this PR should mention the change from replace -> replaceAll instead.
Other than that, the PR seems good.
msivasubramaniaan
changed the title
datho7561
approved these changes
Mar 3, 2025
msivasubramaniaan
deleted the
1078-use-replaceall-instead-of-replace-when-turning-a-label-into-a-regex
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updated eslint version to support replaceAll method
What issues does this PR fix or reference?
#1078
Is it tested? How?
Existing test case