Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix port validation in Create Component from Local Codebase #4552

Conversation

vrubezhny
Copy link
Contributor

rejected promise not handled within 1 second: TypeError: Cannot read properties of undefined (reading 'toString')
extensionHostProcess.js:162
stack trace: TypeError: Cannot read properties of undefined (reading 'toString')
	at validatePortNumber (/home/jeremy/projects/vscode-openshift-tools/source/vscode-openshift-tools/out/src/webview/common-ext/createComponentHelpers.js:170:29)
	at gh.<anonymous> (/home/jeremy/projects/vscode-openshift-tools/source/vscode-openshift-tools/out/src/webview/create-component/createComponentLoader.js:193:95)
	at Generator.next (<anonymous>)
	at /home/jeremy/projects/vscode-openshift-tools/source/vscode-openshift-tools/out/src/webview/create-component/createComponentLoader.js:8:71
	at new Promise (<anonymous>)
	at __awaiter (/home/jeremy/projects/vscode-openshift-tools/source/vscode-openshift-tools/out/src/webview/create-component/createComponentLoader.js:4:12)
	at gh.messageHandler [as value] (/home/jeremy/projects/vscode-openshift-tools/source/vscode-openshift-tools/out/src/webview/create-component/createComponentLoader.js:91:16)

```
rejected promise not handled within 1 second: TypeError: Cannot read properties of undefined (reading 'toString')
extensionHostProcess.js:162
stack trace: TypeError: Cannot read properties of undefined (reading 'toString')
	at validatePortNumber (/home/jeremy/projects/vscode-openshift-tools/source/vscode-openshift-tools/out/src/webview/common-ext/createComponentHelpers.js:170:29)
	at gh.<anonymous> (/home/jeremy/projects/vscode-openshift-tools/source/vscode-openshift-tools/out/src/webview/create-component/createComponentLoader.js:193:95)
	at Generator.next (<anonymous>)
	at /home/jeremy/projects/vscode-openshift-tools/source/vscode-openshift-tools/out/src/webview/create-component/createComponentLoader.js:8:71
	at new Promise (<anonymous>)
	at __awaiter (/home/jeremy/projects/vscode-openshift-tools/source/vscode-openshift-tools/out/src/webview/create-component/createComponentLoader.js:4:12)
	at gh.messageHandler [as value] (/home/jeremy/projects/vscode-openshift-tools/source/vscode-openshift-tools/out/src/webview/create-component/createComponentLoader.js:91:16)
```

Signed-off-by: Victor Rubezhny <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.83%. Comparing base (da60441) to head (37796c1).
Report is 622 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4552       +/-   ##
===========================================
+ Coverage   32.37%   43.83%   +11.45%     
===========================================
  Files          85       99       +14     
  Lines        6505     8067     +1562     
  Branches     1349     1710      +361     
===========================================
+ Hits         2106     3536     +1430     
- Misses       4399     4531      +132     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vrubezhny vrubezhny merged commit fb6ea2a into redhat-developer:main Oct 13, 2024
4 checks passed
@vrubezhny vrubezhny self-assigned this Oct 15, 2024
@adietish
Copy link
Contributor

@vrubezhny can you please tell me if there was an issue that I can link?

@vrubezhny
Copy link
Contributor Author

@vrubezhny can you please tell me if there was an issue that I can link?

@adietish There is no existing issue for this error. Please link the PR itself

@vrubezhny vrubezhny added this to the 1.17.0 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants