Dedupe Deployment error messages in tooltip #4170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrubezhny
force-pushed
the
fix-dedup-deployment-errors-in-tooltip
branch
from
38206a9 to
766a5a8
Compare
|
For example, the same errors from all 5 Pod Containers were deduped into the single
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4170 +/- ##
===========================================
+ Coverage 32.37% 44.00% +11.62%
===========================================
Files 85 91 +6
Lines 6505 7352 +847
Branches 1349 1569 +220
===========================================
+ Hits 2106 3235 +1129
+ Misses 4399 4117 -282 ☔ View full report in Codecov by Sentry. |
datho7561
requested changes
May 30, 2024
vrubezhny
force-pushed
the
fix-dedup-deployment-errors-in-tooltip
branch
2 times, most recently
from
cb9c1db to
04b336e
Compare
datho7561
previously approved these changes
May 30, 2024
The PR deduplicates the same Deployment error messages, showing only 1 message for every problem reason. Also, it limits the number of shown error messages for Deployment and Pod Containers to 3 messages each. Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny
force-pushed
the
fix-dedup-deployment-errors-in-tooltip
branch
from
04b336e to
740d9b8
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR deduplicates the same Deployment error messages, showing only 1 message for every problem reason.
Also, it limits the number of shown error messages for Deployment and Pod Containers to 3 messages each.