Improve error message when podman is present but podman machine isn't #3408
Conversation
| const podmanOnPath = which('podman'); | ||
| if (podmanOnPath) { | ||
| const SETUP_INSTRUCTIONS = 'Open setup instructions'; | ||
| void window.showErrorMessage('Podman is present on the system, but is not fully set up yet.', SETUP_INSTRUCTIONS) |
There was a problem hiding this comment.
@jeffmaury what do you think about this wording?
There was a problem hiding this comment.
I don't think it's gonna fix the issue as Component.odo.isPodmanPresent would return true and code won't be executed
There was a problem hiding this comment.
odo version only seems to report podman as installed if the podman machine is present, so in the case that the binary is on the path but the machine is not set up, it will go to this case. I've tested it on my Windows machine.
There was a problem hiding this comment.
@jeffmaury if you have time, could you please tell what you think of the wording of this message? I'll double check that it shows up under the right circumstances.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3408 +/- ##
==========================================
- Coverage 32.37% 32.30% -0.08%
==========================================
Files 85 85
Lines 6505 6513 +8
Branches 1349 1351 +2
==========================================
- Hits 2106 2104 -2
- Misses 4399 4409 +10 ☔ View full report in Codecov by Sentry. |
datho7561
force-pushed
the
3405-bad-diagnostic-when-podmachine-not-setup
branch
from
0a70a6d to
66f1053
Compare
|
I'm going to work on #3665 as a part of this issue, since odo is not longer actively developed |
datho7561
force-pushed
the
3405-bad-diagnostic-when-podmachine-not-setup
branch
3 times, most recently
from
34c424f to
5fdabb2
Compare
|
Okay. I've updated the pull request so that it no longer uses
This can only be tested on Windows or macOS, since Linux computers (usually) don't use the podman machine (since they can run containers without starting a separate Linux VM). |
|
@msivasubramaniaan can you please review this PR soon ? |
|
@datho7561 Shall I get demo video of it? that would help me to know the step to test the same |
|
Sorry, I don't have access to a Windows computer today. However, here are the steps to try it out:
|
Fixes redhat-developer#3405 Signed-off-by: David Thompson <[email protected]>
Signed-off-by: David Thompson <[email protected]>
datho7561
force-pushed
the
3405-bad-diagnostic-when-podmachine-not-setup
branch
from
5fdabb2 to
e306126
Compare
There was a problem hiding this comment.
LGTM
Sorry for taking much time to review this one.
I have tested all the scenarios on my local and it is working as expected. Thanks @datho7561 for this PR
Fixes #3405, Fixes #3665
Signed-off-by: David Thompson [email protected]