Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show deployment logs doesn't work if you switch projects #3845

Closed
datho7561 opened this issue Jan 25, 2024 · 0 comments · Fixed by #4145
Closed

Show deployment logs doesn't work if you switch projects #3845

datho7561 opened this issue Jan 25, 2024 · 0 comments · Fixed by #4145
Assignees
@vrubezhny
Labels
kind/bug
Milestone
1.14.0

Comments

@datho7561
Copy link
Contributor

The "show deployment logs" feature works by running the command to watch the logs on a timer until it succeeds.

Currently if the user switches projects after creating a new deployment from a container image but before the logs appear, then the notification that says 'opening deployment logs' will be loading forever.

The way to remedy this is to specify the namespace in https://github.com/redhat-developer/vscode-openshift-tools/blob/main/src/explorer.ts#L376, so that even if the user switches namespaces, the correct namespace is being checked for the deployment.
@vrubezhny vrubezhny self-assigned this Apr 24, 2024
@vrubezhny vrubezhny moved this to 🏗 In progress in IDE Cloudaptors May 14, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue May 21, 2024
@vrubezhny
Show deployment logs doesn't work if you switch projects redhat-devel…
1da7392 
…oper#3845

Fixes: redhat-developer#3845

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue May 21, 2024
@vrubezhny
Show deployment logs doesn't work if you switch projects redhat-devel…
3803b8c 
…oper#3845

Fixes: redhat-developer#3845

Signed-off-by: Victor Rubezhny <[email protected]>
@vrubezhny vrubezhny mentioned this issue May 21, 2024
Merged
@vrubezhny vrubezhny moved this from 🏗 In progress to 👀 In review in IDE Cloudaptors May 21, 2024
@datho7561 datho7561 added this to the 1.14.0 milestone May 22, 2024
datho7561 pushed a commit that referenced this issue May 22, 2024
@vrubezhny @datho7561
Show deployment logs doesn't work if you switch projects #3845
9e9170e 
Fixes: #3845

Signed-off-by: Victor Rubezhny <[email protected]>
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in IDE Cloudaptors May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vrubezhny vrubezhny

Labels
kind/bug
Projects
IDE Cloudaptors
Status: ✅ Done
Milestone
1.14.0
Development

Successfully merging a pull request may close this issue.

Show deployment logs doesn't work if you switch projects #3845 vrubezhny/vscode-openshift-tools
2 participants
@vrubezhny @datho7561