Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Create Component from Git" doesn't sanitize the suggested component name #3294

Closed
datho7561 opened this issue Sep 20, 2023 · 0 comments · Fixed by #3396
Closed

"Create Component from Git" doesn't sanitize the suggested component name #3294

datho7561 opened this issue Sep 20, 2023 · 0 comments · Fixed by #3396
Assignees
@vrubezhny
Labels
kind/bug
Milestone
1.10.0

Comments

@datho7561
Copy link
Contributor

eg. create a component from https://github.com/eclipse/lemminx.git (make sure to include the .git at the end)

The suggested component name doesn't get sanitized like it does for the fix introduced in #3150

eg. it suggests lemminx.git instead of the expected lemminx-git
@datho7561 datho7561 assigned datho7561 and unassigned datho7561 Sep 21, 2023
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Oct 3, 2023
@vrubezhny
"Create Component from Git" doesn't sanitize the suggested component …
9bf5103 
…name redhat-developer#3294

Fixes: redhat-developer#3294

Signed-off-by: Victor Rubezhny <[email protected]>
@vrubezhny vrubezhny mentioned this issue Oct 3, 2023
Merged
@vrubezhny vrubezhny self-assigned this Oct 3, 2023
@vrubezhny vrubezhny moved this to 👀 In review in IDE Cloudaptors Oct 3, 2023
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Oct 5, 2023
@vrubezhny
"Create Component from Git" doesn't sanitize the suggested component …
a1a8c79 
…name redhat-developer#3294

Fixes: redhat-developer#3294

Signed-off-by: Victor Rubezhny <[email protected]>
@datho7561 datho7561 added this to the 1.10.0 milestone Oct 5, 2023
datho7561 pushed a commit that referenced this issue Oct 5, 2023
@vrubezhny @datho7561
"Create Component from Git" doesn't sanitize the suggested component …
a72db4f 
…name #3294

Fixes: #3294

Signed-off-by: Victor Rubezhny <[email protected]>
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in IDE Cloudaptors Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vrubezhny vrubezhny

Labels
kind/bug
Projects
IDE Cloudaptors
Archived in project
Milestone
1.10.0
2 participants
@vrubezhny @datho7561