Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Node 20 in release-job only. #3809

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

rgrunber
Copy link
Member

  • ovsx 0.10.0 requires Node >= 20
$ nvm use 18
$ npm install -g ovsx
$ ovsx --version
ovsx requires at least NodeJS version 20. Check your installed version with `node --version`.

- ovsx 0.10.0 requires Node >= 20

Signed-off-by: Roland Grunberg <[email protected]>
@rgrunber rgrunber added this to the End October 2024 milestone Oct 10, 2024
@rgrunber rgrunber self-assigned this Oct 10, 2024
@rgrunber rgrunber requested a review from datho7561 October 10, 2024 16:50
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

ovsx is also installed as part of the packaging step, where nodejs 18 is used, but ovsx is not used during that step, so it shouldn't cause a build error.

@datho7561 datho7561 merged commit 973f3d1 into redhat-developer:master Oct 10, 2024
2 checks passed
@rgrunber rgrunber deleted the node-20-ovsx branch October 10, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants