Use plural form for reload projects command title #2612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sheche <[email protected]>
rgrunber
approved these changes
Aug 9, 2022
There was a problem hiding this comment.
Looks good. Does this also apply to
vscode-java/src/gradle/gradleCodeActionProvider.ts
Lines 33 to 35 in 184111d
Either way, feel free to merge if it doesn't, or once you modify the PR to address that also.
Signed-off-by: sheche <[email protected]>
|
Thanks for notifying that. Let's keep singular for that case since it's updating the targeting project under that context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use plural form here since now we support reload multiple projects when multiple projects exist in workspace.
Signed-off-by: sheche [email protected]