Trigger signature help on completion item selected #2426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sheche <[email protected]>
|
Right. I ran into this and wondered if eclipse-jdtls/eclipse.jdt.ls#2025 might improve the situation. |
rgrunber
approved these changes
Apr 22, 2022
Unfortunately, that PR won't help in this case, since currently the user's selection does not report back to the server. But since we have the completion item command. Technically, it should be achievable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires eclipse-jdtls/eclipse.jdt.ls#2065
Now when a completion item is selected, it will automatically trigger signature help:
The value of the setting
java.signatureHelp.enabledis still disabled by default. The reason is that, currently we cannot get which item is selected and provide that signature correctly. Considering method likeSystem.out.println(), which has multiple overload versions, the current implementation won't work.To solve this problem, we can leverage the command field of the completion item. Send back the selected one's information and cache it. But that needs some refactoring works to be done in IntelliCode as well. So currently, just keep it to
false.Signed-off-by: sheche [email protected]