change max size of client.log

[Eskibear]

improve the case mentioned in #2319

With 100k as max size, sometimes it creates several log files for a single session, which is not convenient for diagnose. E.g. I have to try opening several log files to find the the one containing the command to start Java language server.

This PR simply increases it to 1m, in order to mitigate the inconvenience.

[Eskibear]

BTW, I also considered to create client.log per session, then it would be much clearer to inspect without comparing timestamps.
But seems there's no simple option to set in winston-daily-rotate-file. So I choose this cheap way to mitigate.

[rgrunber]

Looks good to me.

I've run into this as well, when I first started working on the project, but I found it was easier to just look up the logs in the console, since that doesn't get truncated. With that said, this is mainly a problem for the verbose logging, but definitely a great improvement for diagnosing problems.

Only disadvantage I can think of is users would now be uploading a log file that in the worst case is 10x larger, although the current system does risk losing relevant information.

[Eskibear]

...uploading a log file that in the worst case is 10x larger

Exactly. So ideally, how about we rotate client.log per session.
Advantage:

• easy to look up logs
• usually small file size

Disadvantage:

• creates lots of files if you frequently reload window, but that's acceptable if we combine the strategy to only keep logs for 2 days.
• extra effort on implementation of rotation, and update the way to open corresponding client.log

[rgrunber]

For the time being, I'm fine with the current implementation. As you mention, we already rotate the logs every 2 days.

Doing a simple import, I estimated about 500kb of data when logging is verbose.