annotation processor of mapstruct can not generate Impl class in vscode. #1660

yousetme · 2020-10-16T05:24:06Z

Mapstruct has supported IDEA and eclipse to generate copier class automatically，but VSCODE doesn't work.
https://mapstruct.org/documentation/ide-support/

Steps To Reproduce

1.define java class
@Mapper(componentModel = "spring")
public interface AccountingFlowDtoCopier extends ObjectCopier<AccountingFlow, AccountingFlowDto> {
}

2.gradle build works and generate AccountingFlowDtoCopierImpl.class to {projectRootDir}/build dir.

2.VSCODE compile file to {projectRootDir}/bin dir and AccountingFlowDtoCopierImpl.class can not generate.

is there some magic? thank!

The text was updated successfully, but these errors were encountered:

fbricon · 2020-10-16T06:03:12Z

Please attach a sample project reproducing the issue

fbricon · 2020-10-19T14:36:21Z

I tested with a Maven project and it worked fine. Since you're using gradle, you might want to follow the instructions in http://dplatz.de/blog/2018/gradle-apt.html so that annotation processing configuration files can be generated by gradle

yousetme · 2020-10-20T07:15:12Z

Please attach a sample project reproducing the issue

It's my demo project. bin/ dir is generated by VSCODE and build/ dir is generated by "gradle build". bin/ dir does't generate DemoCopierImpl.class but build dir does.
https://github.com/yousetme/mapstruct-gradle-demo

yousetme · 2020-10-20T07:16:56Z

I tested with a Maven project and it worked fine. Since you're using gradle, you might want to follow the instructions in http://dplatz.de/blog/2018/gradle-apt.html so that annotation processing configuration files can be generated by gradle

I have try in VSCODE，but it does't work, perhaps it works with Eclipse.

fbricon · 2020-10-20T09:15:10Z

your example doesn't even build from CLI:

./gradlew build                                ✔  11:12:33 

Welcome to Gradle 5.6.2!

Here are the highlights of this release:
 - Incremental Groovy compilation
 - Groovy compile avoidance
 - Test fixtures for Java projects
 - Manage plugin versions via settings script

For more details see https://docs.gradle.org/5.6.2/release-notes.html

Starting a Gradle Daemon, 6 busy and 1 incompatible Daemons could not be reused, use --status for details

FAILURE: Build failed with an exception.

* Where:
Build file '/Users/fbricon/Dev/souk/mapstruct-gradle-demo/build.gradle' line: 2

* What went wrong:
A problem occurred evaluating root project 'halo'.
> Could not get resource 'http://saos-publish-test.chj.cloud/gradle/version.gradle'.
   > Could not GET 'http://saos-publish-test.chj.cloud/gradle/version.gradle'.
      > saos-publish-test.chj.cloud: nodename nor servname provided, or not known

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 6s

yousetme · 2020-10-20T10:05:24Z

your example doesn't even build from CLI:

./gradlew build                                ✔  11:12:33 

Welcome to Gradle 5.6.2!

Here are the highlights of this release:
 - Incremental Groovy compilation
 - Groovy compile avoidance
 - Test fixtures for Java projects
 - Manage plugin versions via settings script

For more details see https://docs.gradle.org/5.6.2/release-notes.html

Starting a Gradle Daemon, 6 busy and 1 incompatible Daemons could not be reused, use --status for details

FAILURE: Build failed with an exception.

* Where:
Build file '/Users/fbricon/Dev/souk/mapstruct-gradle-demo/build.gradle' line: 2

* What went wrong:
A problem occurred evaluating root project 'halo'.
> Could not get resource 'http://saos-publish-test.chj.cloud/gradle/version.gradle'.
   > Could not GET 'http://saos-publish-test.chj.cloud/gradle/version.gradle'.
      > saos-publish-test.chj.cloud: nodename nor servname provided, or not known

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 6s

https://github.com/yousetme/mapstruct-gradle-demo
So sorry to waste your time, it's my negligence to import some no use code. I have clear it, have a try please. thanks.

yousetme · 2020-10-21T07:50:23Z

this problem is resolved, gradle demo https://github.com/yousetme/mapstruct-gradle-demo is work in VSCODE with http://dplatz.de/blog/2018/gradle-apt.html .
our project is not work in VSCODE, i think it's gradle version or it's dependence version problem.
Thanks!

chiragai · 2020-11-11T10:36:37Z

I have the same problem but I am using maven for the build.
This are the dependency which I am using

<dependency>
      <groupId>org.mapstruct</groupId>
      <artifactId>mapstruct</artifactId>
      <version>${mapstruct.version}</version>
    </dependency>
    <dependency>
      <groupId>org.mapstruct</groupId>
      <artifactId>mapstruct-processor</artifactId>
      <version>${mapstruct.version}</version>
    </dependency>

Here is a build plugin

<plugins>
      <plugin>
        <groupId>org.springframework.boot</groupId>
        <artifactId>spring-boot-maven-plugin</artifactId>
        <configuration>
          <mainClass>xxx</mainClass>
        </configuration>
      </plugin>
      <plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-compiler-plugin</artifactId>
        <version>3.8.0</version>
        <configuration>
          <release>${java.version}</release>
          <annotationProcessorPaths>
            <path>
              <groupId>org.mapstruct</groupId>
              <artifactId>mapstruct-processor</artifactId>
              <version>${mapstruct.version}</version>
            </path>
            <path>
              <groupId>org.projectlombok</groupId>
              <artifactId>lombok</artifactId>
              <version>${lombok.version}</version>
            </path>
          </annotationProcessorPaths>
          <compilerArgs>-Amapstruct.defaultComponentModel=spring</compilerArgs>
        </configuration>
      </plugin>
    </plugins>

No Impl class is generated.
@fbricon any help or suggestion on this. Thank you

mainmethod0126 · 2021-02-16T00:13:06Z

Still not available in VSCODE?

pumano · 2021-03-10T01:08:08Z

got the same problem

PandaGeek1024 · 2021-03-27T22:32:25Z

Getting the same problem, any updates?

PandaGeek1024 · 2021-03-27T23:10:15Z

works fine when building with gradle command, looks like mainly a vscode thing.

snjeza · 2021-03-28T03:49:22Z

@PandaGeek1024 @pumano @chiragai could you attach a project example?

pumano · 2021-04-10T20:57:05Z

@snjeza yes, I prepare repo for it: https://github.com/pumano/vscode-mapstruct-tests
just check via gradle clean test and then try to run via vscode.

You got java.lang.ExceptionInInitializerError which Caused by: java.lang.ClassNotFoundException: Cannot find implementation for com.example.vscode.mapstructdemo.mappers.ExampleMapper

looks like path to generated code by annotation processor not included to tests.

snjeza · 2021-04-12T22:06:57Z

@pumano could you try the following patch:

diff --git a/build.gradle b/build.gradle
index 18beeb8..965f6de 100644
--- a/build.gradle
+++ b/build.gradle
@@ -2,6 +2,7 @@ plugins {
        id 'org.springframework.boot' version '2.4.4'
        id 'io.spring.dependency-management' version '1.0.11.RELEASE'
        id 'java'
+       id 'eclipse'
 }
 
 group = 'com.example.vscode'
@@ -26,3 +27,14 @@ dependencies {
 test {
        useJUnitPlatform()
 }
+
+eclipse {
+    classpath {
+        containers 'org.eclipse.buildship.core.gradleclasspathcontainer'
+        file.whenMerged { cp ->
+            def entries = cp.entries;
+            def src = new org.gradle.plugins.ide.eclipse.model.SourceFolder('build/generated/sources/annotationProcessor/java/main/', null)
+            entries.add(src)
+        } 
+    }
+}

pumano · 2021-04-12T22:15:53Z

@snjeza wow! Works like a charm! Would be good to have it out of the box if possible.

Ok for this simple project problem solved, but for multimodule gradle project - same problem.

snjeza · 2021-04-13T01:27:19Z

Ok for this simple project problem solved, but for multimodule gradle project - same problem.

@pumano could you attach a multimodule project?

pumano · 2021-04-13T08:11:03Z

Ok for this simple project problem solved, but for multimodule gradle project - same problem.

@pumano could you attach a multimodule project?

Ok I will prepare it soon

AriseIGitHub · 2021-05-03T13:24:10Z

I have the same problem. When can you fix it?

ad798 · 2021-06-04T19:35:08Z

Hello everyone! I am happy to say I found a way to solve this. I got it working with Spring Boot + Lombok + Mapstruct with Maven Wrapper. The key is to put the mapstuct and mapstruct-processor as dependencies. Here is how the result pom.xml looks like.

<properties>
	<java.version>11</java.version>
	<org.mapstruct.version>1.4.2.Final</org.mapstruct.version>
</properties>
<dependencies>
        <!--Spring Boot dependencies omitted for brevity-->
	<dependency>
		<groupId>org.projectlombok</groupId>
		<artifactId>lombok</artifactId>
		<optional>true</optional>
	</dependency>
	<dependency>
		<groupId>org.mapstruct</groupId>
		<artifactId>mapstruct</artifactId>
		<version>${org.mapstruct.version}</version>
		<optional>true</optional>
	</dependency>
	<dependency>
		<groupId>org.mapstruct</groupId>
		<artifactId>mapstruct-processor</artifactId>
		<version>${org.mapstruct.version}</version>
		<optional>true</optional>
	</dependency>
</dependencies>

<build>
	<plugins>
		<plugin>
			<groupId>org.springframework.boot</groupId>
			<artifactId>spring-boot-maven-plugin</artifactId>
			<configuration>
				<excludes>
					<exclude>
						<groupId>org.projectlombok</groupId>
						<artifactId>lombok</artifactId>
					</exclude>
					<exclude>
						<groupId>org.mapstruct</groupId>
						<artifactId>mapstruct</artifactId>
					</exclude>
					<exclude>
						<groupId>org.mapstruct</groupId>
						<artifactId>mapstruct-processor</artifactId>
					</exclude>
				</excludes>
			</configuration>
		</plugin>
	</plugins>
</build>

pumano · 2021-06-04T20:09:54Z

@ad798 It's good, but how to solve this via gradle...

Yanxinwei · 2021-07-10T09:23:56Z

I have the same problem but I am using maven for the build.
This are the dependency which I am using

<dependency>
      <groupId>org.mapstruct</groupId>
      <artifactId>mapstruct</artifactId>
      <version>${mapstruct.version}</version>
    </dependency>
    <dependency>
      <groupId>org.mapstruct</groupId>
      <artifactId>mapstruct-processor</artifactId>
      <version>${mapstruct.version}</version>
    </dependency>

Here is a build plugin

<plugins>
      <plugin>
        <groupId>org.springframework.boot</groupId>
        <artifactId>spring-boot-maven-plugin</artifactId>
        <configuration>
          <mainClass>xxx</mainClass>
        </configuration>
      </plugin>
      <plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-compiler-plugin</artifactId>
        <version>3.8.0</version>
        <configuration>
          <release>${java.version}</release>
          <annotationProcessorPaths>
            <path>
              <groupId>org.mapstruct</groupId>
              <artifactId>mapstruct-processor</artifactId>
              <version>${mapstruct.version}</version>
            </path>
            <path>
              <groupId>org.projectlombok</groupId>
              <artifactId>lombok</artifactId>
              <version>${lombok.version}</version>
            </path>
          </annotationProcessorPaths>
          <compilerArgs>-Amapstruct.defaultComponentModel=spring</compilerArgs>
        </configuration>
      </plugin>
    </plugins>

No Impl class is generated.
@fbricon any help or suggestion on this. Thank you

Was this problem solved? I just got the same one. @chiragai Thanks

activedgetechnologies · 2021-08-09T00:18:35Z

@snjeza wow! Works like a charm! Would be good to have it out of the box if possible.

Ok for this simple project problem solved, but for multimodule gradle project - same problem.

yeah!

Yanxinwei · 2021-08-09T01:09:09Z

I have the same problem but I am using maven for the build.
This are the dependency which I am using

<dependency>
      <groupId>org.mapstruct</groupId>
      <artifactId>mapstruct</artifactId>
      <version>${mapstruct.version}</version>
    </dependency>
    <dependency>
      <groupId>org.mapstruct</groupId>
      <artifactId>mapstruct-processor</artifactId>
      <version>${mapstruct.version}</version>
    </dependency>

Here is a build plugin

<plugins>
      <plugin>
        <groupId>org.springframework.boot</groupId>
        <artifactId>spring-boot-maven-plugin</artifactId>
        <configuration>
          <mainClass>xxx</mainClass>
        </configuration>
      </plugin>
      <plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-compiler-plugin</artifactId>
        <version>3.8.0</version>
        <configuration>
          <release>${java.version}</release>
          <annotationProcessorPaths>
            <path>
              <groupId>org.mapstruct</groupId>
              <artifactId>mapstruct-processor</artifactId>
              <version>${mapstruct.version}</version>
            </path>
            <path>
              <groupId>org.projectlombok</groupId>
              <artifactId>lombok</artifactId>
              <version>${lombok.version}</version>
            </path>
          </annotationProcessorPaths>
          <compilerArgs>-Amapstruct.defaultComponentModel=spring</compilerArgs>
        </configuration>
      </plugin>
    </plugins>

No Impl class is generated.
@fbricon any help or suggestion on this. Thank you

Was this problem solved? I just got the same one. @chiragai Thanks

I solved this problem by adding this dependency in my project module, while my project compiled succeessfully but didn't generate implementation classes.

`

   <groupId>org.mapstruct</groupId>
   <artifactId>mapstruct-processor</artifactId>
   <scope>compile</scope>

`

ivadoncheva · 2022-02-07T09:21:48Z

Hello, I am getting the same error when mapstruct generates impl class for my Mapper, one of the classes is not listed as import. Then if I open the impl class I'm able import the package, but mapstruct doesn't not import it during generation of the class and therefore the class could not be used. I'm using gradle and Intelij. Is there any updates or work done on this?

javohircomunity · 2022-02-14T12:15:55Z

I have the same problem but I am using gradle for the build.
When I run project then mapper impl class couldn't generate.
How can i solve the problem.

ivadoncheva · 2022-02-14T14:12:41Z

@javohircomunity I have managed to find a way to get this running by using in my interface the following annotation:

@Mapper(componentModel = "spring", imports = <YourClass>.class)
public interface SomeClassMapper {
// the SomeClassMapperImpl which is generated by mapstruct now imports YourClass
}

javohircomunity · 2022-02-15T04:45:25Z

@javohircomunity I have managed to find a way to get this running by using in my interface the following annotation:
@Mapper(componentModel = "spring", imports = <YourClass>.class)
public interface SomeClassMapper {
// the SomeClassMapperImpl which is generated by mapstruct now imports YourClass
}

I haven't any import class, There are many String fields.

mishi321 · 2022-04-04T06:23:32Z

*Impl.class didn't generate by vscode run , but it work well by gradle bootRun. So everytime I copy *Impl.class from build(gradle compile folder) to bin(vscode compile folder) by hand let vscode to run.

laDanz · 2022-07-07T08:38:00Z

@ad798 It's good, but how to solve this via gradle...

@snjeza 's patch is fixing it: #1660 (comment)

appleseedexm · 2022-07-12T07:01:40Z

There also seems a specific setup where mapstruct doesnt build *Impl of abstract classes extending other classes. We have in our project one specific abstract class which doesnt get an *Impl class, but in IntelliJ it does. As soon as I remove the "extends from", the *Impl is created. I've not come around to investigate this and create a sample project, but I'll update here as soon as I have a better bug report.

yousetme closed this as completed Oct 21, 2020

pumano mentioned this issue Apr 10, 2021

'Cannot find implementation' for mapstruct mappers microsoft/vscode-java-test#1171

Closed

snjeza reopened this Apr 12, 2021

jdneo mentioned this issue Nov 11, 2022

Support Gradle annotation processing eclipse-jdtls/eclipse.jdt.ls#2319

Merged

jdneo closed this as completed in eclipse-jdtls/eclipse.jdt.ls#2319 Nov 25, 2022

This was referenced Nov 2, 2024

Run the Java Simulate Robot Code command using gradle instead of the debugger extension wpilibsuite/vscode-wpilib#716

Closed

Update Java build.gradle files with eclipse workaround wpilibsuite/vscode-wpilib#717

Closed

ThadHouse mentioned this issue Nov 3, 2024

Add eclipse workaround for annotation processors wpilibsuite/GradleRIO#759

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

annotation processor of mapstruct can not generate Impl class in vscode. #1660

annotation processor of mapstruct can not generate Impl class in vscode. #1660

yousetme commented Oct 16, 2020

fbricon commented Oct 16, 2020

fbricon commented Oct 19, 2020

yousetme commented Oct 20, 2020

yousetme commented Oct 20, 2020

fbricon commented Oct 20, 2020

yousetme commented Oct 20, 2020

yousetme commented Oct 21, 2020

chiragai commented Nov 11, 2020 •

edited

Loading

mainmethod0126 commented Feb 16, 2021

pumano commented Mar 10, 2021

PandaGeek1024 commented Mar 27, 2021

PandaGeek1024 commented Mar 27, 2021

snjeza commented Mar 28, 2021

pumano commented Apr 10, 2021 •

edited

Loading

snjeza commented Apr 12, 2021

pumano commented Apr 12, 2021 •

edited

Loading

snjeza commented Apr 13, 2021

pumano commented Apr 13, 2021

AriseIGitHub commented May 3, 2021

ad798 commented Jun 4, 2021

pumano commented Jun 4, 2021

Yanxinwei commented Jul 10, 2021

activedgetechnologies commented Aug 9, 2021

Yanxinwei commented Aug 9, 2021 •

edited

Loading

ivadoncheva commented Feb 7, 2022 •

edited

Loading

javohircomunity commented Feb 14, 2022

ivadoncheva commented Feb 14, 2022

javohircomunity commented Feb 15, 2022

mishi321 commented Apr 4, 2022

laDanz commented Jul 7, 2022

appleseedexm commented Jul 12, 2022

annotation processor of mapstruct can not generate Impl class in vscode. #1660

annotation processor of mapstruct can not generate Impl class in vscode. #1660

Comments

yousetme commented Oct 16, 2020

Steps To Reproduce

fbricon commented Oct 16, 2020

fbricon commented Oct 19, 2020

yousetme commented Oct 20, 2020

yousetme commented Oct 20, 2020

fbricon commented Oct 20, 2020

yousetme commented Oct 20, 2020

yousetme commented Oct 21, 2020

chiragai commented Nov 11, 2020 • edited Loading

mainmethod0126 commented Feb 16, 2021

pumano commented Mar 10, 2021

PandaGeek1024 commented Mar 27, 2021

PandaGeek1024 commented Mar 27, 2021

snjeza commented Mar 28, 2021

pumano commented Apr 10, 2021 • edited Loading

snjeza commented Apr 12, 2021

pumano commented Apr 12, 2021 • edited Loading

snjeza commented Apr 13, 2021

pumano commented Apr 13, 2021

AriseIGitHub commented May 3, 2021

ad798 commented Jun 4, 2021

pumano commented Jun 4, 2021

Yanxinwei commented Jul 10, 2021

activedgetechnologies commented Aug 9, 2021

Yanxinwei commented Aug 9, 2021 • edited Loading

ivadoncheva commented Feb 7, 2022 • edited Loading

javohircomunity commented Feb 14, 2022

ivadoncheva commented Feb 14, 2022

javohircomunity commented Feb 15, 2022

mishi321 commented Apr 4, 2022

laDanz commented Jul 7, 2022

appleseedexm commented Jul 12, 2022

chiragai commented Nov 11, 2020 •

edited

Loading

pumano commented Apr 10, 2021 •

edited

Loading

pumano commented Apr 12, 2021 •

edited

Loading

Yanxinwei commented Aug 9, 2021 •

edited

Loading

ivadoncheva commented Feb 7, 2022 •

edited

Loading