-
Notifications
You must be signed in to change notification settings - Fork 89
Add shortNames to Servicebindingrequest in CRD #136
Add shortNames to Servicebindingrequest in CRD #136
Conversation
/test lint |
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
==========================================
+ Coverage 66.45% 66.88% +0.43%
==========================================
Files 6 6
Lines 462 468 +6
==========================================
+ Hits 307 313 +6
Misses 112 112
Partials 43 43
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes would be overwritten if someone did a
operator-sdk generate k8s
Followed by a
operator-sdk generate openapi
This is how you should add the short names
operator-framework/operator-sdk#1593
And then run the above two commands.
Thanks @sbose78, I will refactor accordingly |
@akashshinde Let's get this in, this is a very useful fix. |
@sbose78 Done |
Handled here c042dc3 |
/test e2e |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbose78 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…upport * upstream/master: Upgrade controller runtime version (redhat-developer#157) Add shortNames to Servicebindingrequest in CRD (redhat-developer#136)
Fixes #135
What this PR does
To get created servicebindingrequest resources, we can use
oc get sbr
or
oc get sbrs