Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

Add shortNames to Servicebindingrequest in CRD #136

Conversation

akashshinde
Copy link
Contributor

Fixes #135

What this PR does
To get created servicebindingrequest resources, we can use
oc get sbr
or
oc get sbrs

@akashshinde
Copy link
Contributor Author

/test lint

@codecov
Copy link

codecov bot commented Aug 21, 2019

Codecov Report

Merging #136 into master will increase coverage by 0.43%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
+ Coverage   66.45%   66.88%   +0.43%     
==========================================
  Files           6        6              
  Lines         462      468       +6     
==========================================
+ Hits          307      313       +6     
  Misses        112      112              
  Partials       43       43
Impacted Files Coverage Δ
pkg/controller/servicebindingrequest/binder.go 68.49% <0%> (+1.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5624ba...c042dc3. Read the comment docs.

Copy link
Member

@sbose78 sbose78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes would be overwritten if someone did a
operator-sdk generate k8s
Followed by a
operator-sdk generate openapi

This is how you should add the short names
operator-framework/operator-sdk#1593

And then run the above two commands.

@akashshinde
Copy link
Contributor Author

akashshinde commented Aug 21, 2019

Thanks @sbose78, I will refactor accordingly

@sbose78
Copy link
Member

sbose78 commented Aug 23, 2019

@akashshinde Let's get this in, this is a very useful fix.

@akashshinde
Copy link
Contributor Author

akashshinde commented Aug 26, 2019

@akashshinde Let's get this in, this is a very useful fix.

@sbose78 Done

@akashshinde
Copy link
Contributor Author

These changes would be overwritten if someone did a
operator-sdk generate k8s
Followed by a
operator-sdk generate openapi

This is how you should add the short names
operator-framework/operator-sdk#1593

And then run the above two commands.

Handled here c042dc3

@akashshinde
Copy link
Contributor Author

/test e2e

@otaviof
Copy link
Member

otaviof commented Aug 28, 2019

/lgtm

@sbose78
Copy link
Member

sbose78 commented Aug 28, 2019

/lgtm
/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbose78

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 62d8a1f into redhat-developer:master Aug 28, 2019
akashshinde added a commit to akashshinde/service-binding-operator that referenced this pull request Aug 29, 2019
…upport

* upstream/master:
  Upgrade controller runtime version (redhat-developer#157)
  Add shortNames to Servicebindingrequest in CRD (redhat-developer#136)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: There is need to have short name for ServiceBindingRequest while listing resource using oc or kubectl
6 participants