Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docker): ensure yarn is on the path (RHIDP-4211) #1913

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

nickboldt
Copy link
Member

@nickboldt nickboldt commented Nov 8, 2024

What does this PR do?

chore(docker): ensure yarn is on the path so we can refer to it inside package.json files
this fix is for downstream but might as well do the same for upstream for now to be consistent

Signed-off-by: Nick Boldt [email protected]

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

https://issues.redhat.com/browse/RHIDP-4211

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

  • Code produced is complete
  • Code builds without errors
  • Tests are covering the bugfix
  • Relevant user documentation updated
  • Relevant contributing documentation updated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

…e package.json files

this fix is for downstream but might as well do the same for upstream for now to be consistent

Signed-off-by: Nick Boldt <[email protected]>
@nickboldt nickboldt requested a review from a team as a code owner November 8, 2024 17:35
@nickboldt nickboldt changed the title chore(docker): ensure yarn is on the path so... chore(docker): ensure yarn is on the path (RHIDP-4211) Nov 8, 2024
Copy link

sonarqubecloud bot commented Nov 8, 2024

Copy link
Collaborator

@schultzp2020 schultzp2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: schultzp2020

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 8, 2024
Copy link
Contributor

github-actions bot commented Nov 8, 2024

@nickboldt nickboldt merged commit 4e70265 into main Nov 8, 2024
13 of 15 checks passed
@nickboldt nickboldt deleted the add-yarn-to-path-for-downstream branch November 8, 2024 18:36
teknaS47 pushed a commit to teknaS47/backstage-showcase that referenced this pull request Nov 28, 2024
…e package.json files (redhat-developer#1913)

this fix is for downstream but might as well do the same for upstream for now to be consistent

Signed-off-by: Nick Boldt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants