Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use staging Devfile registry for PR tests #7129

Merged
merged 8 commits into from
Oct 27, 2023
Merged

Use staging Devfile registry for PR tests #7129

merged 8 commits into from
Oct 27, 2023

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Oct 23, 2023 •
edited
Loading

What type of PR is this:
/area testing

What does this PR do / why we need it:

Which issue(s) this PR fixes:
Fixes #7110

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Oct 23, 2023
@netlify
Copy link

netlify bot commented Oct 23, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 0daac77
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6538c3e259b80d00086af042

@openshift-ci openshift-ci bot added the area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering label Oct 23, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 23, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rm3l rm3l temporarily deployed to internal October 23, 2023 14:57 — with GitHub Actions Inactive
@rm3l rm3l added this to the v3.16.0 🚀 milestone Oct 23, 2023
@odo-robot
Copy link

odo-robot bot commented Oct 23, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit 84924a9 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 23, 2023 •
edited
Loading

NoCluster Tests on commit 84924a9 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 23, 2023 •
edited
Loading

Unit Tests on commit 84924a9 finished successfully.
View logs: TXT HTML

@github-actions
Copy link
Contributor

✅ Deploy Preview on internal cluster ready!

Name Link
🔨 Latest commit 424c590
😎 Deploy Preview https://odo-dev-pr-7129.odo-test-kubernete-449701-49529fc6e6a4a9fe7ebba9a3db5b55c4-0000.eu-de.containers.appdomain.cloud/

@odo-robot
Copy link

odo-robot bot commented Oct 23, 2023 •
edited
Loading

Validate Tests on commit 84924a9 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 23, 2023 •
edited
Loading

Kubernetes Tests on commit 84924a9 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 23, 2023 •
edited
Loading

Windows Tests (OCP) on commit 84924a9 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 23, 2023 •
edited
Loading

Kubernetes Docs Tests on commit d77ca3e finished successfully.
View logs: TXT HTML

@rm3l rm3l force-pushed the 7110-use-staging-devfile-registry-for-pr-tests branch from 424c590 to 70b6504 Compare October 23, 2023 15:40
@rm3l rm3l temporarily deployed to internal October 23, 2023 15:40 — with GitHub Actions Inactive
@odo-robot
Copy link

odo-robot bot commented Oct 23, 2023 •
edited
Loading

OpenShift Tests on commit 84924a9 finished successfully.
View logs: TXT HTML

@github-actions
Copy link
Contributor

✅ Deploy Preview on internal cluster ready!

Name Link
🔨 Latest commit 70b6504
😎 Deploy Preview https://odo-dev-pr-7129.odo-test-kubernete-449701-49529fc6e6a4a9fe7ebba9a3db5b55c4-0000.eu-de.containers.appdomain.cloud/

@rm3l rm3l closed this Oct 23, 2023
@rm3l rm3l reopened this Oct 23, 2023
@rm3l rm3l temporarily deployed to internal October 23, 2023 16:07 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

✅ Deploy Preview on internal cluster ready!

Name Link
🔨 Latest commit 70b6504
😎 Deploy Preview https://odo-dev-pr-7129.odo-test-kubernete-449701-49529fc6e6a4a9fe7ebba9a3db5b55c4-0000.eu-de.containers.appdomain.cloud/

@rm3l rm3l closed this Oct 24, 2023
@rm3l rm3l reopened this Oct 24, 2023
@rm3l rm3l temporarily deployed to internal October 24, 2023 09:01 — with GitHub Actions Inactive
rm3l added 2 commits October 24, 2023 11:02
@rm3l
Revert using a DEVFILE_PROXY env var
e8acf73 
There is no proxy deployed in the internal test cluster.
As such, this env var no longer makes sense.
@rm3l
To help troubleshoot, display the resolved Devfile registry URL
672fe1f
@rm3l rm3l force-pushed the 7110-use-staging-devfile-registry-for-pr-tests branch from 70b6504 to 672fe1f Compare October 24, 2023 09:02
@rm3l rm3l temporarily deployed to internal October 24, 2023 23:03 — with GitHub Actions Inactive
@rm3l rm3l changed the title Use staging Devfile registry for PR tests [WIP] Use staging Devfile registry for PR tests Oct 24, 2023
@github-actions
Copy link
Contributor

✅ Deploy Preview on internal cluster ready!

Name Link
🔨 Latest commit 2d758d3
😎 Deploy Preview https://odo-dev-pr-7129.odo-test-kubernete-449701-49529fc6e6a4a9fe7ebba9a3db5b55c4-0000.eu-de.containers.appdomain.cloud/

@rm3l rm3l closed this Oct 24, 2023
@rm3l rm3l reopened this Oct 24, 2023
@rm3l rm3l temporarily deployed to internal October 24, 2023 23:48 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

✅ Deploy Preview on internal cluster ready!

Name Link
🔨 Latest commit 2d758d3
😎 Deploy Preview https://odo-dev-pr-7129.odo-test-kubernete-449701-49529fc6e6a4a9fe7ebba9a3db5b55c4-0000.eu-de.containers.appdomain.cloud/

@rm3l rm3l temporarily deployed to internal October 25, 2023 07:29 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

✅ Deploy Preview on internal cluster ready!

Name Link
🔨 Latest commit 0daac77
😎 Deploy Preview https://odo-dev-pr-7129.odo-test-kubernete-449701-49529fc6e6a4a9fe7ebba9a3db5b55c4-0000.eu-de.containers.appdomain.cloud/

@rm3l rm3l marked this pull request as ready for review October 27, 2023 07:38
@rm3l rm3l temporarily deployed to internal October 27, 2023 07:38 — with GitHub Actions Inactive
@rm3l rm3l changed the title [WIP] Use staging Devfile registry for PR tests Use staging Devfile registry for PR tests Oct 27, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Oct 27, 2023
@openshift-ci openshift-ci bot requested a review from kadel October 27, 2023 07:39
rm3l
rm3l commented Oct 27, 2023
View reviewed changes
Copy link
Member Author

@rm3l rm3l left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests passing on IBM Cloud and GitHub using the Devfile staging registry.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2023

@rm3l: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link
Contributor

✅ Deploy Preview on internal cluster ready!

Name Link
🔨 Latest commit 0daac77
😎 Deploy Preview https://odo-dev-pr-7129.odo-test-kubernete-449701-49529fc6e6a4a9fe7ebba9a3db5b55c4-0000.eu-de.containers.appdomain.cloud/

@rm3l rm3l added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Oct 27, 2023
@rm3l rm3l self-assigned this Oct 27, 2023
@rm3l
Copy link
Member Author

rm3l commented Oct 27, 2023

All tests passing on IBM Cloud and GitHub using the Devfile staging registry.
But for some reason, the status checks from IBM Cloud are not reflected on this PR. This will be investigated and addressed as part of #7131

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
/override OpenShift-Integration-tests/OpenShift-Integration-tests
/override Unit-Tests/Unit-Tests
/override validator/Validate

@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2023

@rm3l: Overrode contexts on behalf of rm3l: Kubernetes-Integration-Tests/Kubernetes-Integration-Tests, OpenShift-Integration-tests/OpenShift-Integration-tests, Unit-Tests/Unit-Tests, validator/Validate

In response to this:

All tests passing on IBM Cloud and GitHub using the Devfile staging registry.
But for some reason, the status checks from IBM Cloud are not reflected on this PR. This will be investigated and addressed as part of #7131

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
/override OpenShift-Integration-tests/OpenShift-Integration-tests
/override Unit-Tests/Unit-Tests
/override validator/Validate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot merged commit 5d4a6ef into redhat-developer:main Oct 27, 2023
@openshift-ci openshift-ci bot temporarily deployed to internal October 27, 2023 07:54 Inactive
@rm3l rm3l deleted the 7110-use-staging-devfile-registry-for-pr-tests branch October 27, 2023 07:56
@github-actions
Copy link
Contributor

🔨 Deploy Preview deleted from internal cluster!

Name Link
🔨 Latest commit 0daac77
😎 Deploy Preview https://odo-dev-pr-7129.odo-test-kubernete-449701-49529fc6e6a4a9fe7ebba9a3db5b55c4-0000.eu-de.containers.appdomain.cloud/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadel kadel Awaiting requested review from kadel

Assignees

@rm3l rm3l

Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
v3.16.0 🚀
Development

Successfully merging this pull request may close these issues.

Use staging Devfile registry for PR tests
1 participant
@rm3l