Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning if version of Devfile is different from 2.2.0 #7065

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Warning if version of Devfile is different from 2.2.0 #7065

merged 2 commits into from
Sep 5, 2023

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Sep 1, 2023

What type of PR is this:

/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #7048

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Sep 1, 2023
@netlify
Copy link

netlify bot commented Sep 1, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 4465778
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64f6cf27daca7c000848ea84

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Sep 1, 2023
@openshift-ci openshift-ci bot requested review from kadel and rm3l September 1, 2023 14:30
@feloy feloy force-pushed the feature-7048/ui-alert-devfile-version branch from 065a0a0 to f1b45b7 Compare September 1, 2023 14:35
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Sep 1, 2023
@odo-robot
Copy link

odo-robot bot commented Sep 1, 2023 •
edited
Loading

NoCluster Tests on commit bee208d finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 1, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit bee208d finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 1, 2023 •
edited
Loading

Unit Tests on commit bee208d finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 1, 2023 •
edited
Loading

Validate Tests on commit bee208d finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 1, 2023 •
edited
Loading

Kubernetes Tests on commit bee208d finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 1, 2023 •
edited
Loading

Windows Tests (OCP) on commit bee208d finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 1, 2023 •
edited
Loading

Kubernetes Docs Tests on commit e21b80f finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 1, 2023 •
edited
Loading

OpenShift Tests on commit bee208d finished successfully.
View logs: TXT HTML

rm3l
rm3l reviewed Sep 4, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the schema version is changed from 2.1.0 to 2.2.0 from the YAML view and then persisted to the filesystem, the snackbar notification was still present.

Screencast.from.2023-09-04.11-17-21.webm

Do you think it would be possible to dismiss it if the schema version is the expected one?

@rm3l rm3l added the area/Dev-UI Issues or PRs related to the odo dev Web UI, a.k.a Devfile Builder label Sep 4, 2023
@feloy feloy force-pushed the feature-7048/ui-alert-devfile-version branch from 3c1e11e to 5c48b03 Compare September 4, 2023 14:41
@feloy
Copy link
Contributor Author

feloy commented Sep 4, 2023

When the schema version is changed from 2.1.0 to 2.2.0 from the YAML view and then persisted to the filesystem, the snackbar notification was still present.

Screencast.from.2023-09-04.11-17-21.webm
Do you think it would be possible to dismiss it if the schema version is the expected one?

No, I don't think it would help that much. It is not a status bar, just a warning at some point in time.

@feloy feloy force-pushed the feature-7048/ui-alert-devfile-version branch from 5c48b03 to 4465778 Compare September 5, 2023 06:48
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 5, 2023
@openshift-merge-robot openshift-merge-robot merged commit 3f93ac0 into redhat-developer:main Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@kadel kadel Awaiting requested review from kadel

Assignees

@rm3l rm3l

Labels
area/Dev-UI Issues or PRs related to the odo dev Web UI, a.k.a Devfile Builder kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI] Display persistent warning message if Devfile Schema version is < 2.2.0
3 participants
@feloy @rm3l @openshift-merge-robot