-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UX issue when exec command fails to run as part of a deploy command #6673
Fix UX issue when exec command fails to run as part of a deploy command #6673
Conversation
For the context, before the changes, the "Execution output" message was displayed on the same line as the spinner, e.g.: ``` ↪ Executing command: ◓ Executing command in container (command: exec-deploy)Execution output: /bin/sh: line 1: helm: command not found ✗ Executing command in container (command: exec-deploy) [8s] ✗ failed to execute (command: exec-deploy) ``` This is now fixed by ending the spinner as soon as possible, and then displaying the command output: ``` ↪ Executing command: ✗ Executing command in container (command: exec-deploy) [8s] Execution output: /bin/sh: line 1: helm: command not found ✗ failed to execute (command: exec-deploy) ```
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
Kudos, SonarCloud Quality Gate passed!
|
Flaky E2E test - reported in #6582 /override windows-integration-test/Windows-test |
@rm3l: Overrode contexts on behalf of rm3l: windows-integration-test/Windows-test In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this:
/kind bug
/area UX
/area deploy
What does this PR do / why we need it:
I stumbled upon this issue while reviewing #6672.
Before the changes, the
Execution output:
message was displayed on the same line as the spinner, like so:This is now fixed by ending the spinner as soon as the command is done, and then displaying the command output. Example output:
Which issue(s) this PR fixes:
Related to #5701
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: