Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch Pods to pass pod security admission #6602

Merged
merged 9 commits into from
Mar 20, 2023
Merged

Patch Pods to pass pod security admission #6602

merged 9 commits into from
Mar 20, 2023

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Feb 16, 2023 •
edited
Loading

Get pod security policy set on the current namespace to patch pod template accordingly

fixes partially #6339

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Feb 16, 2023
@netlify
Copy link

netlify bot commented Feb 16, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit c7b5b16
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64182610f08bff000713b267

@openshift-ci openshift-ci bot requested review from anandrkskd and rm3l February 16, 2023 14:32
@odo-robot
Copy link

odo-robot bot commented Feb 16, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit 94577ca finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 16, 2023 •
edited
Loading

Validate Tests on commit 94577ca finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 16, 2023 •
edited
Loading

NoCluster Tests on commit 94577ca finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 16, 2023 •
edited
Loading

Unit Tests on commit 94577ca finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 16, 2023 •
edited
Loading

Kubernetes Tests on commit 94577ca finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 16, 2023 •
edited
Loading

Windows Tests (OCP) on commit 94577ca finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 16, 2023 •
edited
Loading

OpenShift Tests on commit 94577ca finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 16, 2023 •
edited
Loading

Kubernetes Docs Tests on commit 86b271d finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the refacto/get-containers branch 3 times, most recently from 12b719f to cd0e269 Compare February 20, 2023 08:59
@feloy feloy force-pushed the refacto/get-containers branch from cd0e269 to 9037fac Compare March 9, 2023 08:20
@feloy feloy mentioned this pull request Mar 9, 2023
Closed
@feloy feloy force-pushed the refacto/get-containers branch from de540d6 to 7807c6c Compare March 9, 2023 15:30
@feloy feloy closed this Mar 10, 2023
@feloy feloy reopened this Mar 10, 2023
@feloy feloy mentioned this pull request Mar 10, 2023
Closed
4 tasks
@feloy feloy changed the title [wip] Refacto GetContainers/GetDeployment Patch Pods to pass pod security admission Mar 10, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Mar 10, 2023
@feloy feloy closed this Mar 10, 2023
@feloy feloy reopened this Mar 10, 2023
@feloy feloy requested review from valaparthvi and removed request for anandrkskd March 10, 2023 12:49
rm3l
rm3l requested changes Mar 14, 2023
View reviewed changes
tests/integration/cmd_dev_test.go Outdated Show resolved Hide resolved
tests/integration/cmd_dev_test.go Outdated Show resolved Hide resolved
.golangci.yaml Show resolved Hide resolved
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Mar 18, 2023
@feloy feloy force-pushed the refacto/get-containers branch from 2d65b58 to d775fb5 Compare March 20, 2023 07:35
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Mar 20, 2023
@feloy feloy requested a review from rm3l March 20, 2023 07:40
@feloy feloy force-pushed the refacto/get-containers branch 2 times, most recently from 061f10b to aaca724 Compare March 20, 2023 09:14
@feloy feloy force-pushed the refacto/get-containers branch from aaca724 to c7b5b16 Compare March 20, 2023 09:23
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 20, 2023
@openshift-merge-robot openshift-merge-robot merged commit 93d1330 into redhat-developer:main Mar 20, 2023
@rm3l rm3l added this to the v3.9.0 🚀 milestone Mar 20, 2023
@rm3l rm3l added the area/dev Issues or PRs related to `odo dev` label Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

Assignees

@rm3l rm3l

Labels
area/dev Issues or PRs related to `odo dev` lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
v3.9.0 🚀
Development

Successfully merging this pull request may close these issues.
3 participants
@feloy @rm3l @openshift-merge-robot