Fix some flaky tests #5586

feloy · 2022-03-22T18:39:01Z

What type of PR is this:

/kind bug

What does this PR do / why we need it:

Which issue(s) this PR fixes:

odo delete command tests
/go/src/github.com/redhat-developer/odo/tests/integration/devfile/cmd_delete_test.go:13
  when a component is bootstrapped
  /go/src/github.com/redhat-developer/odo/tests/integration/devfile/cmd_delete_test.go:32
    when the component is deployed in DEV mode and dev mode stopped
    /go/src/github.com/redhat-developer/odo/tests/integration/devfile/cmd_delete_test.go:68
      when the component is deleted using its name and namespace from another directory
      /go/src/github.com/redhat-developer/odo/tests/integration/devfile/cmd_delete_test.go:76
        when odo delete command is run again with nothing deployed on the cluster
        /go/src/github.com/redhat-developer/odo/tests/integration/devfile/cmd_delete_test.go:94
          should output that there are no resources to be deleted [It]
          /go/src/github.com/redhat-developer/odo/tests/integration/devfile/cmd_delete_test.go:102
          Expected
              
              <string>: Searching resources to delete, please wait...
              This will delete "mynodejs" from the namespace "cmd-delete-test102goj".
               •  The component contains the following resources that will get deleted:
              	- PodMetrics: mynodejs-app-6d84cf9975-jw4pv
              The component "mynodejs" is successfully deleted from namespace "cmd-delete-test102goj"
              
          to contain substring
              <string>: No resource found for component "mynodejs" in namespace "cmd-delete-test102goj"

Fixes [Flake] odo dev test should run odo dev on initial namespace failing on periodic jobs #5568

Bug ps -ef receiving SIGURG: replacing ps with a grep on proc/*/cmdline as Docker seems to send SIGURG signals from time to time (Signal 23 (SIGURG) Docker event flood flatcar/Flatcar#315)

PR acceptance criteria:

Unit test
Integration test
Documentation

How to test changes / Special notes to the reviewer:

netlify · 2022-03-22T18:39:06Z

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name	Link
🔨 Latest commit	`3d3a8f5`
🔍 Latest deploy log	https://app.netlify.com/sites/odo-docusaurus-preview/deploys/623c9af10055cc0009b2bdaf

odo-robot · 2022-03-22T18:46:10Z

Unit Tests on commit bfc0a93 finished successfully.
View logs: TXT HTML

odo-robot · 2022-03-22T18:54:46Z

Kubernetes Tests on commit bfc0a93 finished successfully.
View logs: TXT HTML

odo-robot · 2022-03-22T19:08:22Z

OpenShift Tests on commit bfc0a93 finished successfully.
View logs: TXT HTML

feloy · 2022-03-22T19:20:30Z

Kubernetes Tests on commit finished with errors. View logs: TXT HTML

@anandrkskd Could you please increase the number of nodes on this cluster?

[odo] I0322 18:47:39.453150   11036 events.go:53] Warning Event: Count: 5, Reason: FailedScheduling, Message: 0/3 nodes are available: 3 Insufficient memory.

odo-robot · 2022-03-22T19:31:30Z

Validate Tests on commit bfc0a93 finished successfully.
View logs: TXT HTML

feloy · 2022-03-22T21:29:50Z

/test v4.10-integration-e2e
Infra error

feloy · 2022-03-23T04:59:26Z

/test v4.10-integration-e2e
Infra error

rm3l · 2022-03-23T08:28:09Z

Thanks! I had the exact same issue reported in another PR, and was wondering what could cause this,... until I saw this PR :)

/lgtm

valaparthvi · 2022-03-24T06:31:33Z

/retest-required

valaparthvi · 2022-03-24T07:18:09Z

tests/integration/devfile/cmd_delete_test.go

+						Eventually(func() string {
+							stdOut = helper.Cmd("odo", "delete", "component", "--name", cmpName, "--namespace", commonVar.Project, "-f").ShouldPass().Out()
+							return stdOut
+						}, 60, 3).Should(ContainSubstring("No resource found for component %q in namespace %q", cmpName, commonVar.Project))


I think instead of this, you can wait for Pods to not be present.

No, I would really want to test that the delete component command displays that no resources found

I meant, you wait for the pods to not be present, and then run the delete command to ensure it gives the right message. Why do you choose otherwise?

cdrage

/lgtm

valaparthvi · 2022-03-25T06:44:11Z

@feloy Why have IBM cloud tests not triggered yet?
I mean can you re-push so that they'll be triggered?

valaparthvi · 2022-03-25T06:51:25Z

/approve
Tests pass locally with multiple runs.

openshift-ci · 2022-03-25T06:51:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: valaparthvi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~tests/OWNERS~~ [valaparthvi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sonarqubecloud · 2022-03-25T06:52:17Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

feloy · 2022-03-25T07:09:00Z

IBM Cloud OpenShift & Kubernetes tests pass

Exceeded limit MAX_RRSETS_BY_ZONE for zone: ...

/override ci/prow/v4.10-integration-e2e

openshift-ci · 2022-03-25T07:09:03Z

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.10-integration-e2e

In response to this:

IBM Cloud OpenShift & Kubernetes tests pass
Exceeded limit MAX_RRSETS_BY_ZONE for zone: ...
/override ci/prow/v4.10-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

* Eventually after delete component * Fix for ps -ef error

openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 22, 2022

openshift-ci bot requested review from mohammedzee1000 and rnapoles-rh March 22, 2022 18:39

feloy force-pushed the tests-fix-after-delete branch from a3d5dbd to 2e5240e Compare March 22, 2022 20:31

feloy changed the title ~~Eventually after delete component~~ Fix some flaky tests Mar 23, 2022

openshift-ci bot assigned rm3l Mar 23, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 23, 2022

feloy force-pushed the tests-fix-after-delete branch from 2e5240e to 3d3a8f5 Compare March 23, 2022 10:09

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 23, 2022

valaparthvi suggested changes Mar 24, 2022

View reviewed changes

openshift-ci bot assigned valaparthvi Mar 24, 2022

feloy added 2 commits March 24, 2022 17:23

Eventually after delete component

89ffb5d

Fix for ps -ef error

ac862b7

feloy force-pushed the tests-fix-after-delete branch from 3d3a8f5 to ac862b7 Compare March 24, 2022 16:23

cdrage approved these changes Mar 24, 2022

View reviewed changes

openshift-ci bot assigned cdrage Mar 24, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 24, 2022

valaparthvi closed this Mar 25, 2022

valaparthvi reopened this Mar 25, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Mar 25, 2022

openshift-merge-robot merged commit bad34a9 into redhat-developer:main Mar 25, 2022

cdrage pushed a commit to cdrage/odo that referenced this pull request Aug 31, 2022

Fix some flaky tests (redhat-developer#5586)

0c2b07d

* Eventually after delete component * Fix for ps -ef error

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix some flaky tests #5586

Fix some flaky tests #5586

feloy commented Mar 22, 2022 •

edited

Loading

netlify bot commented Mar 22, 2022 •

edited

Loading

odo-robot bot commented Mar 22, 2022 •

edited

Loading

odo-robot bot commented Mar 22, 2022 •

edited

Loading

odo-robot bot commented Mar 22, 2022 •

edited

Loading

feloy commented Mar 22, 2022

odo-robot bot commented Mar 22, 2022 •

edited

Loading

feloy commented Mar 22, 2022

feloy commented Mar 23, 2022

rm3l commented Mar 23, 2022 •

edited

Loading

valaparthvi commented Mar 24, 2022

valaparthvi Mar 24, 2022

feloy Mar 24, 2022

valaparthvi Mar 24, 2022

cdrage left a comment

valaparthvi commented Mar 25, 2022 •

edited

Loading

valaparthvi commented Mar 25, 2022

openshift-ci bot commented Mar 25, 2022

sonarqubecloud bot commented Mar 25, 2022

feloy commented Mar 25, 2022

openshift-ci bot commented Mar 25, 2022

Fix some flaky tests #5586

Fix some flaky tests #5586

Conversation

feloy commented Mar 22, 2022 • edited Loading

netlify bot commented Mar 22, 2022 • edited Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

odo-robot bot commented Mar 22, 2022 • edited Loading

odo-robot bot commented Mar 22, 2022 • edited Loading

odo-robot bot commented Mar 22, 2022 • edited Loading

feloy commented Mar 22, 2022

odo-robot bot commented Mar 22, 2022 • edited Loading

feloy commented Mar 22, 2022

feloy commented Mar 23, 2022

rm3l commented Mar 23, 2022 • edited Loading

valaparthvi commented Mar 24, 2022

valaparthvi Mar 24, 2022

Choose a reason for hiding this comment

feloy Mar 24, 2022

Choose a reason for hiding this comment

valaparthvi Mar 24, 2022

Choose a reason for hiding this comment

cdrage left a comment

Choose a reason for hiding this comment

valaparthvi commented Mar 25, 2022 • edited Loading

valaparthvi commented Mar 25, 2022

openshift-ci bot commented Mar 25, 2022

sonarqubecloud bot commented Mar 25, 2022

feloy commented Mar 25, 2022

openshift-ci bot commented Mar 25, 2022

feloy commented Mar 22, 2022 •

edited

Loading

netlify bot commented Mar 22, 2022 •

edited

Loading

odo-robot bot commented Mar 22, 2022 •

edited

Loading

odo-robot bot commented Mar 22, 2022 •

edited

Loading

odo-robot bot commented Mar 22, 2022 •

edited

Loading

odo-robot bot commented Mar 22, 2022 •

edited

Loading

rm3l commented Mar 23, 2022 •

edited

Loading

valaparthvi commented Mar 25, 2022 •

edited

Loading