Fixing a bug in the page object initialization

redfin · Dec 13, 2019 · 6ba9103 · 6ba9103
1 parent 700e3d2
commit 6ba9103
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 7 deletions.
diff --git a/README.md b/README.md
@@ -21,7 +21,7 @@ Via maven:
 <dependency>
     <groupId>com.redfin</groupId>
     <artifactId>patient-selenium</artifactId>
-    <version>3.1.0</version>
+    <version>3.1.1</version>
 </dependency>
 ```
 

diff --git a/pom.xml b/pom.xml
@@ -8,7 +8,7 @@
 
     <groupId>com.redfin</groupId>
     <artifactId>patient-selenium</artifactId>
-    <version>3.1.0</version>
+    <version>3.1.1</version>
     <modelVersion>4.0.0</modelVersion>
     <packaging>jar</packaging>
 

diff --git a/src/main/java/com/redfin/selenium/AbstractBaseWidgetObject.java b/src/main/java/com/redfin/selenium/AbstractBaseWidgetObject.java
@@ -27,14 +27,18 @@ protected final E getWidgetElement() {
         return widgetElement;
     }
 
-    /*
-     * Only intended for use by the AbstractPageObjectInitializer so make
-     * the visibility package private.
-     */
+    // ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+    // Package private methods intended for use only by AbstractPageObjectInitializer
+    // ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
     void setWidgetElement(E value) {
         if (null != widgetElement) {
             throw new PageObjectInitializationException("This widget was already initialized");
         }
         this.widgetElement = value;
     }
+
+    boolean isWidgetElementSet() {
+        return null != widgetElement;
+    }
 }
diff --git a/src/main/java/com/redfin/selenium/AbstractPageObjectInitializer.java b/src/main/java/com/redfin/selenium/AbstractPageObjectInitializer.java
@@ -293,7 +293,7 @@ private void initializeField(Object object,
                 if (isWidget.get()) {
                     if (builtValue.get() instanceof AbstractBaseWidgetObject<?, ?, ?, ?>) {
                         AbstractBaseWidgetObject<?, ?, ?, ?> widget = (AbstractBaseWidgetObject<?, ?, ?, ?>) builtValue.get();
-                        if (null != widget.getWidgetElement()) {
+                        if (widget.isWidgetElementSet()) {
                             throw new PageObjectInitializationException(String.format("Received a widget from %s with a non-null base element for field: %s", buildMethodNameString, field));
                         }
                     } else {