Merge pull request #34 from red0124/improvement/getline_update

Fix reallocation issues with non-POSIX get_line
red0124 · Feb 23, 2024 · a27fd12 · a27fd12
2 parents f8fdb97 + c0d3087
commit a27fd12
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/include/ss/common.hpp b/include/ss/common.hpp
@@ -62,10 +62,10 @@ ssize_t get_line(char** lineptr, size_t* n, FILE* fp) {
         size_t line_used = strlen(*lineptr);
         size_t buff_used = strlen(buff);
 
-        if (*n < buff_used + line_used) {
+        if (*n <= buff_used + line_used) {
             size_t new_n = *n * 2;
 
-            auto new_lineptr = static_cast<char*>(realloc(*lineptr, *n));
+            auto new_lineptr = static_cast<char*>(realloc(*lineptr, new_n));
             if (new_lineptr == nullptr) {
                 errno = ENOMEM;
                 return -1;

diff --git a/ssp.hpp b/ssp.hpp
@@ -674,10 +674,10 @@ ssize_t get_line(char** lineptr, size_t* n, FILE* fp) {
         size_t line_used = strlen(*lineptr);
         size_t buff_used = strlen(buff);
 
-        if (*n < buff_used + line_used) {
+        if (*n <= buff_used + line_used) {
             size_t new_n = *n * 2;
 
-            auto new_lineptr = static_cast<char*>(realloc(*lineptr, *n));
+            auto new_lineptr = static_cast<char*>(realloc(*lineptr, new_n));
             if (new_lineptr == nullptr) {
                 errno = ENOMEM;
                 return -1;