[Fix] name of the robotframework keyword Set NVidia GPU Accelerator
#998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proper name is `Set GPU Accelerator`.
Without this change the test fails with following error:
```
==============================================================================
1046
Verify Number Of Available GPUs Is Correct With Machine Autoscaler... | PASS |
1047
------------------------------------------------------------------------------
1048
Verify Node Autoscales And Then Scales Down :: Tries spawning a se... | FAIL |
1049
No keyword with name 'Set NVidia GPU Accelerator' found. Did you mean:
1050
JupyterHubSpawner.Set GPU Accelerator
1051
------------------------------------------------------------------------------
1052
Tests.Jupyterhub.Autoscaling-Gpus :: Tests for a scenario in which... | FAIL |
1053
2 tests, 1 passed, 1 failed
```
jstourac
force-pushed
the
fixSetGpuAccelerator
branch
from
118700d to
5ff99c7
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Drurun failures reduced from 9 to 6. Ready for review, @jgarciao - it would be nice to merge even for 1.34, I believe. |
FedeAlonso
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
It has come because an error I reviewed with @bdattoma where I have already updated "Set GPU Accelerator" in order to be generic but on GH still showed "Set NVidia GPU Accelerator". We did not know what was really happening and the tests run OK.
Sorry for the inconvenience and thanks for fixing it @jstourac .
LGTM
jgarciao
added
the
enhancements
jgarciao
approved these changes
Oct 31, 2023
jgarciao
pushed a commit
to jgarciao/ods-ci
that referenced
this pull request
Nov 6, 2023
…red-hat-data-services#998) Proper name is `Set GPU Accelerator`. Without this change the test fails with following error: ``` ============================================================================== 1046 Verify Number Of Available GPUs Is Correct With Machine Autoscaler... | PASS | 1047 ------------------------------------------------------------------------------ 1048 Verify Node Autoscales And Then Scales Down :: Tries spawning a se... | FAIL | 1049 No keyword with name 'Set NVidia GPU Accelerator' found. Did you mean: 1050 JupyterHubSpawner.Set GPU Accelerator 1051 ------------------------------------------------------------------------------ 1052 Tests.Jupyterhub.Autoscaling-Gpus :: Tests for a scenario in which... | FAIL | 1053 2 tests, 1 passed, 1 failed ```
ChughShilpa
pushed a commit
to ChughShilpa/ods-ci
that referenced
this pull request
Nov 28, 2023
…red-hat-data-services#998) Proper name is `Set GPU Accelerator`. Without this change the test fails with following error: ``` ============================================================================== 1046 Verify Number Of Available GPUs Is Correct With Machine Autoscaler... | PASS | 1047 ------------------------------------------------------------------------------ 1048 Verify Node Autoscales And Then Scales Down :: Tries spawning a se... | FAIL | 1049 No keyword with name 'Set NVidia GPU Accelerator' found. Did you mean: 1050 JupyterHubSpawner.Set GPU Accelerator 1051 ------------------------------------------------------------------------------ 1052 Tests.Jupyterhub.Autoscaling-Gpus :: Tests for a scenario in which... | FAIL | 1053 2 tests, 1 passed, 1 failed ```
ChughShilpa
pushed a commit
to ChughShilpa/ods-ci
that referenced
this pull request
Jan 2, 2024
…red-hat-data-services#998) Proper name is `Set GPU Accelerator`. Without this change the test fails with following error: ``` ============================================================================== 1046 Verify Number Of Available GPUs Is Correct With Machine Autoscaler... | PASS | 1047 ------------------------------------------------------------------------------ 1048 Verify Node Autoscales And Then Scales Down :: Tries spawning a se... | FAIL | 1049 No keyword with name 'Set NVidia GPU Accelerator' found. Did you mean: 1050 JupyterHubSpawner.Set GPU Accelerator 1051 ------------------------------------------------------------------------------ 1052 Tests.Jupyterhub.Autoscaling-Gpus :: Tests for a scenario in which... | FAIL | 1053 2 tests, 1 passed, 1 failed ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proper name is
Set GPU Accelerator.Without this change the test fails with following error: