Add support to create DSC without any conditon for rhods24 #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tarun Kumar <[email protected]>
tarukumar
changed the title
jstourac
previously approved these changes
Oct 30, 2023
Signed-off-by: Tarun Kumar <[email protected]>
|
LGTM, any successful run to prove this is working as expected? Also, I suppose this needs to wait for merge until 1.34 branch is created, right? |
yes...and one run has been successful already. |
|
@tarukumar looks like this change needs to be incorporated 3dcde98 - test run here |
Signed-off-by: Tarun Kumar <[email protected]>
Signed-off-by: Tarun Kumar <[email protected]>
mwaykole
approved these changes
Nov 2, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
jgarciao
pushed a commit
to jgarciao/ods-ci
that referenced
this pull request
Nov 6, 2023
…ata-services#996) * Add fix for rhods 2.4 Signed-off-by: Tarun Kumar <[email protected]> * Add trusty ai to dsc Signed-off-by: Tarun Kumar <[email protected]> * Add trusty ai Signed-off-by: Tarun Kumar <[email protected]> * Add fix for model serving Signed-off-by: Tarun Kumar <[email protected]> --------- Signed-off-by: Tarun Kumar <[email protected]>
ChughShilpa
pushed a commit
to ChughShilpa/ods-ci
that referenced
this pull request
Nov 28, 2023
…ata-services#996) * Add fix for rhods 2.4 Signed-off-by: Tarun Kumar <[email protected]> * Add trusty ai to dsc Signed-off-by: Tarun Kumar <[email protected]> * Add trusty ai Signed-off-by: Tarun Kumar <[email protected]> * Add fix for model serving Signed-off-by: Tarun Kumar <[email protected]> --------- Signed-off-by: Tarun Kumar <[email protected]>
ChughShilpa
pushed a commit
to ChughShilpa/ods-ci
that referenced
this pull request
Jan 2, 2024
…ata-services#996) * Add fix for rhods 2.4 Signed-off-by: Tarun Kumar <[email protected]> * Add trusty ai to dsc Signed-off-by: Tarun Kumar <[email protected]> * Add trusty ai Signed-off-by: Tarun Kumar <[email protected]> * Add fix for model serving Signed-off-by: Tarun Kumar <[email protected]> --------- Signed-off-by: Tarun Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From RHODS 2.4 all the channel will have v2 operator. In this PR we are removing the condition to apply DSC and keep it as a default.
PS: We can also remove the condition for component verification using update channel but for now the above changes should work for RHODS 2.4