Compiled upload download yaml for testing purpose #982
Conversation
diegolovison
force-pushed
the
compiled_upload
branch
from
edd26c6 to
4394e13
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
jgarciao
added
enhancements
| _parsed_args = vars(_parser.parse_args()) | ||
|
|
||
| _outputs = send_file(**_parsed_args) | ||
| image: registry.access.redhat.com/ubi8/python-38 |
There was a problem hiding this comment.
ubi8/python-38 sounds pretty old, is that ok to have such an old version?
There was a problem hiding this comment.
This is the compiled file. I can update it on next PR
| valueFrom: | ||
| fieldRef: | ||
| fieldPath: metadata.labels['custom.tekton.dev/originalPipelineRun'] | ||
| - image: registry.redhat.io/ubi8/python-39@sha256:3523b184212e1f2243e76d8094ab52b01ea3015471471290d011625e1763af61 |
There was a problem hiding this comment.
and now we have ubi8/python-39@sha256:3523b...
probably it is ok but using the same python image might be a good idea
There was a problem hiding this comment.
Ok. Going to sync all in other PR
| - sh | ||
| - -ec | ||
| - | | ||
| program_path=$(mktemp) |
There was a problem hiding this comment.
Have you considered storing the script logic in a configmap?
There was a problem hiding this comment.
It is the compiled file
|
lgtm, pls check the comments by Andrej |
Please keep two commits.
The compiled yaml file is for manual testing. There is no Polarion Test yet.