Update OpenShift Pipelines to latest version #979
Conversation
diegolovison
commented
Oct 16, 2023
•
diegolovison
commented
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| IF "4.10" in "${oc_version}" | ||
| ${openshift_pipelines_version}= Set Variable pipelines-1.8" | ||
| ELSE IF "4.11" in "${oc_version}" | ||
| IF "4.11" in "${oc_version}" |
Check notice
Code scanning / Robocop
Variable '{{ name }}' in '{{ block_name }}' condition has unnecessary string conversion
| @@ -46,8 +43,10 @@ | |||
| ELSE | |||
| ${openshift_pipelines_version}= Set Variable pipelines-1.11 | |||
| END | |||
| ELSE IF "4.14" in "${oc_version}" | |||
Check notice
Code scanning / Robocop
Variable '{{ name }}' in '{{ block_name }}' condition has unnecessary string conversion
Robot Results
|
ods_ci/tests/Resources/Page/Operators/OpenShiftPipelines.resource
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
We should try to detect if the operator is already installed and do nothing in that case (to make this keyword faster)
Once the OpenShift Pipelines operator is installed, we need to wait a little bit more (e.g. adding Sleep 30s) so RHODS Dashboard will properly detect that it is available. We have seen the pipeline tests in Smoke failing because of this.
We could use the existing keywords Install ISV Operator From OperatorHub Via CLI, Wait Until Operator Subscription Last Condition Is and Wait For Pods To Be Ready as it is done by Install Service Mesh Stack in ods_ci/tests/Tests/400__ods_dashboard/420__model_serving/422__model_serving_llm.robot
There was a problem hiding this comment.
Sleep is not good. We need to find the right way and replace https://github.com/red-hat-data-services/ods-ci/blob/8008f0619953cc510aea3a9d1ba01af520ab0abc/ods_ci/tests/Resources/Page/Operators/OpenShiftPipelines.resource#L58-L59 with the proper solution
There was a problem hiding this comment.
We should try to detect if the operator is already installed and do nothing in that case (to make this keyword faster)
Hi @diegolovison this is something we need to implement for Component Dependency Testing (something like interop testing) where all dependent operators (e.g. pipelines) are already installed. Please let me know if that's something you are already working on or if some help from my side is needed (e.g. due to your other assignments).
There was a problem hiding this comment.
Should be addressed in other PR.
This is for update the version.
|
Hi @jgarciao is there any reason why we don't use the channel latest at |
We support multiple version |
That's ok but hardcoding the versions into tests is not ideal and should be parameterized. Of course, that's not the goal of this issue right now and we can consider it as a future enhancement. Btw, using the channel 'latest' we will always use the latest supported version in the appropeiate Openshift version, for example |
|
@apodhrad Here is the support matrix for OpenShift Pipelines: https://docs.openshift.com/pipelines/1.12/about/op-release-notes.html. As they support multiple versions of their operator, we try to test as many options as possible, but in an automated way (we didn't want to add another parameter in Jenkins). That's why the logic is hardcoded like this. Looking at the support matrix, if we used "latest" OpenShift Pipelines 1.11 wouldn't be tested, as for OCP 4.11 latest is 1.10 and for OCP 4.12 is 1.12 |
diegolovison
force-pushed
the
pipe_update
branch
from
8008f06 to
2ce2929
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Done. Ready for review |
jgarciao
added
enhancements
* Update OpenShift Pipelines to latest version * OpenStack with 1.12
* Update OpenShift Pipelines to latest version * OpenStack with 1.12
* Update OpenShift Pipelines to latest version * OpenStack with 1.12
