Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check uninstall osd cluster #972

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Conversation

kornys
Copy link
Contributor

@kornys kornys commented Oct 9, 2023

I saw several times in jenkins that unstall osd job failed due to wrong check if cluster exists. I saw that cluster was unstalled but ocm describe returned non zero ecode but contains string about exception and it is not evaluated as None.

@kornys kornys added the utils Enhancements in scripts and CI/CD (PR will be listed in release-notes) label Oct 9, 2023
@kornys kornys requested a review from aloganat October 9, 2023 14:05
@kornys kornys self-assigned this Oct 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
370 0 0 370 100

@jgarciao jgarciao self-requested a review October 17, 2023 11:54
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kornys
Copy link
Contributor Author

kornys commented Oct 18, 2023

@jgarciao thanks for approve but Im not able to merge it due to rights on this repo🙂

@diegolovison diegolovison merged commit 885dbe9 into master Oct 25, 2023
@diegolovison
Copy link
Contributor

@kornys I believe there weren't enough approvals for this PR ( It should be >= 2 )

@jgarciao jgarciao deleted the fix-return-of-describe branch November 28, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
utils Enhancements in scripts and CI/CD (PR will be listed in release-notes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants