Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Custom Serving Runtime UI test suite #964

Merged
merged 26 commits into from
Oct 10, 2023

Conversation

bdattoma
Copy link
Contributor

@bdattoma bdattoma commented Oct 5, 2023

This PRs aims to add the first automated test cases for Custom Serving Runtime feature, in particular:

  • Verify RHODS Admins can import a Custom Serving Runtime by uploading a yaml file (ODS-2276 - Smoke)
  • Verify RHODS Admins can delete a Custom Serving Runtime (ODS-2279 - Smoke)
  • Verify RHODS users can deploy a model using a Custom Serving Runtime (ODS-2281 - Sanity)

@bdattoma bdattoma added needs testing Needs to be tested in Jenkins new test New test(s) added (PR will be listed in release-notes) labels Oct 5, 2023
@bdattoma bdattoma self-assigned this Oct 5, 2023
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Robocop found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
370 0 0 370 100

@bdattoma bdattoma force-pushed the f/customruntimes-1 branch from 4e73567 to ca56cc0 Compare October 6, 2023 11:43
@bdattoma bdattoma marked this pull request as ready for review October 6, 2023 11:51
@bdattoma bdattoma added verified This PR has been tested with Jenkins and removed needs testing Needs to be tested in Jenkins labels Oct 9, 2023
@bdattoma
Copy link
Contributor Author

bdattoma commented Oct 9, 2023

PR Validation

  1. verified CustomServingRuntime suite + DS project suite on CI: rhods-ci-pr-test/2026/
    Two failures:
  • Verify User Can Access Only Its Owned Projects: failing bcos the presence of a DS Project created out of test run, i.e., 'test'
  • Verify User Can Edit A Data Science Project: known issue in the cluster (OCPBUGS-19435)

None of the failures are related/caused to the code under this PR

  1. verified model serving suite on CI: rhods-ci-pr-test/2027. 100% pass

@bdattoma bdattoma requested a review from lugi0 October 9, 2023 14:11
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@FedeAlonso FedeAlonso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdattoma bdattoma merged commit 38f721b into red-hat-data-services:master Oct 10, 2023
ChughShilpa pushed a commit to ChughShilpa/ods-ci that referenced this pull request Nov 28, 2023
* make open settings kw generic pt1

Signed-off-by: bdattoma <[email protected]>

* add custom serving runtime suite

Signed-off-by: bdattoma <[email protected]>

* apply changes to Open dashboard settings kw calls

Signed-off-by: bdattoma <[email protected]>

* add basic keyword to upload a runtime template

Signed-off-by: bdattoma <[email protected]>

* add ods-2276

Signed-off-by: bdattoma <[email protected]>

* add ovms-custom template

Signed-off-by: bdattoma <[email protected]>

* add click action common kw

Signed-off-by: bdattoma <[email protected]>

* add serving runtime deletion kw

Signed-off-by: bdattoma <[email protected]>

* add ods-2279

Signed-off-by: bdattoma <[email protected]>

* check if details page is already open

Signed-off-by: bdattoma <[email protected]>

* make model server kw working on DSProject page

Signed-off-by: bdattoma <[email protected]>

* add ODS-2281 and final suite setup

Signed-off-by: bdattoma <[email protected]>

* add kw to delete single dsproject from cli

Signed-off-by: bdattoma <[email protected]>

* final suite setup/teardown

Signed-off-by: bdattoma <[email protected]>

* move runtime deletion to suite teardown

Signed-off-by: bdattoma <[email protected]>

* remove continue keyword

Signed-off-by: bdattoma <[email protected]>

* remove wrong arg from call

Signed-off-by: bdattoma <[email protected]>

* fix setup and teardown

Signed-off-by: bdattoma <[email protected]>

* fix eventual runtime creation

Signed-off-by: bdattoma <[email protected]>

* fix open section options menu

Signed-off-by: bdattoma <[email protected]>

* fix runtime deletion from cli

Signed-off-by: bdattoma <[email protected]>

* fix dryrun

Signed-off-by: bdattoma <[email protected]>

* fix dryrun (2)

Signed-off-by: bdattoma <[email protected]>

* fix dryrun (3)

Signed-off-by: bdattoma <[email protected]>

* increase pod timeout for runtime

Signed-off-by: bdattoma <[email protected]>

---------

Signed-off-by: bdattoma <[email protected]>
ChughShilpa pushed a commit to ChughShilpa/ods-ci that referenced this pull request Jan 2, 2024
* make open settings kw generic pt1

Signed-off-by: bdattoma <[email protected]>

* add custom serving runtime suite

Signed-off-by: bdattoma <[email protected]>

* apply changes to Open dashboard settings kw calls

Signed-off-by: bdattoma <[email protected]>

* add basic keyword to upload a runtime template

Signed-off-by: bdattoma <[email protected]>

* add ods-2276

Signed-off-by: bdattoma <[email protected]>

* add ovms-custom template

Signed-off-by: bdattoma <[email protected]>

* add click action common kw

Signed-off-by: bdattoma <[email protected]>

* add serving runtime deletion kw

Signed-off-by: bdattoma <[email protected]>

* add ods-2279

Signed-off-by: bdattoma <[email protected]>

* check if details page is already open

Signed-off-by: bdattoma <[email protected]>

* make model server kw working on DSProject page

Signed-off-by: bdattoma <[email protected]>

* add ODS-2281 and final suite setup

Signed-off-by: bdattoma <[email protected]>

* add kw to delete single dsproject from cli

Signed-off-by: bdattoma <[email protected]>

* final suite setup/teardown

Signed-off-by: bdattoma <[email protected]>

* move runtime deletion to suite teardown

Signed-off-by: bdattoma <[email protected]>

* remove continue keyword

Signed-off-by: bdattoma <[email protected]>

* remove wrong arg from call

Signed-off-by: bdattoma <[email protected]>

* fix setup and teardown

Signed-off-by: bdattoma <[email protected]>

* fix eventual runtime creation

Signed-off-by: bdattoma <[email protected]>

* fix open section options menu

Signed-off-by: bdattoma <[email protected]>

* fix runtime deletion from cli

Signed-off-by: bdattoma <[email protected]>

* fix dryrun

Signed-off-by: bdattoma <[email protected]>

* fix dryrun (2)

Signed-off-by: bdattoma <[email protected]>

* fix dryrun (3)

Signed-off-by: bdattoma <[email protected]>

* increase pod timeout for runtime

Signed-off-by: bdattoma <[email protected]>

---------

Signed-off-by: bdattoma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new test New test(s) added (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants