Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the machine pool exiting function #956

Merged
merged 1 commit into from
Sep 28, 2023
Merged

fix the machine pool exiting function #956

merged 1 commit into from
Sep 28, 2023

Conversation

tarukumar
Copy link
Contributor

Observed that this function always retrun True evnthough machine poll doesn't exist. Whne machine pool doesn't exists ocm return empty string

@github-actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
364 0 0 364 100

@tarukumar tarukumar requested a review from aloganat September 28, 2023 06:30
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@aloganat aloganat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tarukumar tarukumar self-assigned this Sep 28, 2023
@tarukumar tarukumar added the verified This PR has been tested with Jenkins label Sep 28, 2023
Copy link
Contributor

@FedeAlonso FedeAlonso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tarukumar tarukumar merged commit 727286e into red-hat-data-services:master Sep 28, 2023
ChughShilpa pushed a commit to ChughShilpa/ods-ci that referenced this pull request Nov 28, 2023
ChughShilpa pushed a commit to ChughShilpa/ods-ci that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verified This PR has been tested with Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants