Fix installation of OpenShift Pipelines #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was failing for 4.14.0-rc1 Signed-off-by: Jorge Garcia Oncins <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -29,9 +29,9 @@ | |||
| ${oc_version}= Get OpenShift Version | |||
| ${is_self_managed}= Is RHODS Self-Managed | |||
| ${platform}= Fetch Cluster Platform Type | |||
| IF ${oc_version} == "4.10" | |||
| IF "${oc_version}" == "4.10" | |||
Check notice
Code scanning / Robocop
Variable '{{ name }}' in '{{ block_name }}' condition has unnecessary string conversion
| ${openshift_pipelines_version}= Set Variable pipelines-1.8" | ||
| ELSE IF ${oc_version} == "4.11" | ||
| ELSE IF "${oc_version}" == "4.11" |
Check notice
Code scanning / Robocop
Variable '{{ name }}' in '{{ block_name }}' condition has unnecessary string conversion
Robot Results
|
kornys
approved these changes
Sep 21, 2023
lugi0
approved these changes
Sep 21, 2023
ChughShilpa
pushed a commit
to ChughShilpa/ods-ci
that referenced
this pull request
Nov 28, 2023
It was failing for 4.14.0-rc1 Signed-off-by: Jorge Garcia Oncins <[email protected]>
ChughShilpa
pushed a commit
to ChughShilpa/ods-ci
that referenced
this pull request
Jan 2, 2024
It was failing for 4.14.0-rc1 Signed-off-by: Jorge Garcia Oncins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was failing for 4.14.0-rc1