Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong import of operating system lib #933

Merged
merged 4 commits into from
Sep 21, 2023
Merged

Fix wrong import of operating system lib #933

merged 4 commits into from
Sep 21, 2023

Conversation

kornys
Copy link
Contributor

@kornys kornys commented Sep 19, 2023

No description provided.

@kornys kornys self-assigned this Sep 19, 2023
@@ -1,7 +1,7 @@
*** Settings ***
Documentation Collections of keywords to register a cluster to RHM
Library OpenShiftLibrary
Library ../../venv/lib64/python3.8/site-packages/robot/libraries/OperatingSystem.py
Library OperatingSystem

Check warning

Code scanning / Robocop

BuiltIn library import '{{ builtin_import }}' should be placed before '{{ custom_import }}'

BuiltIn library import 'OperatingSystem' should be placed before 'OpenShiftLibrary'
@github-actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
359 0 0 359 100

@kornys kornys added the enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) label Sep 19, 2023
@kornys kornys changed the title Fix wrong import or operating system lib Fix wrong import of operating system lib Sep 19, 2023
@kornys kornys requested a review from aloganat September 20, 2023 14:50
@jgarciao jgarciao merged commit 4654c2c into master Sep 21, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

ChughShilpa pushed a commit to ChughShilpa/ods-ci that referenced this pull request Nov 28, 2023
ChughShilpa pushed a commit to ChughShilpa/ods-ci that referenced this pull request Jan 2, 2024
@bdattoma bdattoma deleted the fix-import-os branch May 29, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants