-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fix for odh-nightlies on managed cluster #915
Merged
tarukumar
merged 1 commit into
red-hat-data-services:master
from
tarukumar:fix_mannaed_uninstall
Sep 7, 2023
Merged
Add fix for odh-nightlies on managed cluster #915
tarukumar
merged 1 commit into
red-hat-data-services:master
from
tarukumar:fix_mannaed_uninstall
Sep 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tarun Kumar <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
... Oc Get kind=Namespace field_selector=metadata.name=redhat-ods-operator AND | ||
... Oc Get kind=CatalogSource namespace=redhat-ods-operator | ||
... field_selector=metadata.name=addon-managed-odh-catalog | ||
IF "${UPDATE_CHANNEL}" == "odh-nightlies" |
Check notice
Code scanning / Robocop
Variable '{{ name }}' in '{{ block_name }}' condition has unnecessary string conversion
Variable '${UPDATE_CHANNEL}' in 'IF' condition has unnecessary string conversion
Robot Results
|
mwaykole
approved these changes
Sep 7, 2023
aloganat
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
lugi0
pushed a commit
to lugi0/ods-ci
that referenced
this pull request
Sep 11, 2023
Signed-off-by: Tarun Kumar <[email protected]>
ChughShilpa
pushed a commit
to ChughShilpa/ods-ci
that referenced
this pull request
Nov 28, 2023
Signed-off-by: Tarun Kumar <[email protected]>
ChughShilpa
pushed a commit
to ChughShilpa/ods-ci
that referenced
this pull request
Jan 2, 2024
Signed-off-by: Tarun Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.