Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix for odh-nightlies on managed cluster #915

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Add fix for odh-nightlies on managed cluster #915

merged 1 commit into from
Sep 7, 2023

Conversation

tarukumar
Copy link
Contributor

No description provided.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

... Oc Get kind=Namespace field_selector=metadata.name=redhat-ods-operator AND
... Oc Get kind=CatalogSource namespace=redhat-ods-operator
... field_selector=metadata.name=addon-managed-odh-catalog
IF "${UPDATE_CHANNEL}" == "odh-nightlies"

Check notice

Code scanning / Robocop

Variable '{{ name }}' in '{{ block_name }}' condition has unnecessary string conversion

Variable '${UPDATE_CHANNEL}' in 'IF' condition has unnecessary string conversion
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
358 0 0 358 100

Copy link
Contributor

@aloganat aloganat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tarukumar tarukumar changed the title Add fix for odh-nightlies on manaed cluster Add fix for odh-nightlies on managed cluster Sep 7, 2023
@tarukumar tarukumar merged commit c09fa35 into red-hat-data-services:master Sep 7, 2023
lugi0 pushed a commit to lugi0/ods-ci that referenced this pull request Sep 11, 2023
ChughShilpa pushed a commit to ChughShilpa/ods-ci that referenced this pull request Nov 28, 2023
ChughShilpa pushed a commit to ChughShilpa/ods-ci that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants