-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce number of IDE errors and wrong imports #913
Reduce number of IDE errors and wrong imports #913
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Robocop found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Robot Results
|
I personally don't like having every time the Library name in the keyword:
Of course, if the majority of the team agrees with this choice, let's merge it |
@bdattoma I am not sure if it reduces readability of the code especially if there are two sources from where the method could be called. Both Pycharm and VScode raised it as a warning which made us thinking why and what exactly is going on within the step. Unless there is a better solution (some config for robot lib?) I think this is a good solution |
I think there is nothing wrong going on with the test step itself. We set the library search order (i.e., |
I also didn't find any config for robotframework-lsp which can respect library order |
@bdattoma I just found setting in robotframework-lsp to disable this lint warning -> So I will remove SeleniumLibrary prefix from methods and leave just import fixes. And update doc what it shouldbe setup in robotgramework-lsp |
163746e
to
eb3aa91
Compare
eb3aa91
to
9907434
Compare
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgmt, thanks!
just found setting in robotframework-lsp to disable this lint warning
which setting of robotframework-lsp are you referring to?
"robot.lint.keywordResolvesToMultipleKeywords": false |
No description provided.