Update nightlies install to V2 #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Giorgi <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Robocop found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Robot Results
|
tarukumar
reviewed
Sep 6, 2023
| Apply DataScienceCluster CustomResource dsc_name=${DSC_NAME} | ||
| END | ||
| ${dashboard} = Is Component Enabled dashboard ${DSC_NAME} | ||
| IF ("${UPDATE_CHANNEL}" == "stable" or "${UPDATE_CHANNEL}" == "beta" or "${UPDATE_CHANNEL}" == "odh-nightlies") or "${dashboard}" == "true" # robocop: disable | ||
| IF ("${UPDATE_CHANNEL}" == "stable" or "${UPDATE_CHANNEL}" == "beta") or "${dashboard}" == "true" | ||
| Wait For Pods Numbers 5 |
There was a problem hiding this comment.
for nightly number of dashboard pod is 2 now
Signed-off-by: Luca Giorgi <[email protected]>
mwaykole
previously approved these changes
Sep 6, 2023
Signed-off-by: Luca Giorgi <[email protected]>
Signed-off-by: Luca Giorgi <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
mwaykole
approved these changes
Sep 7, 2023
lugi0
added a commit
to lugi0/ods-ci
that referenced
this pull request
Sep 11, 2023
* Update nightlies install to V2 Signed-off-by: Luca Giorgi <[email protected]> * Hardcode NS variables for nightlies Signed-off-by: Luca Giorgi <[email protected]> * update dashboard check for nightlies Signed-off-by: Luca Giorgi <[email protected]> * Modify component checks Signed-off-by: Luca Giorgi <[email protected]> --------- Signed-off-by: Luca Giorgi <[email protected]>
ChughShilpa
pushed a commit
to ChughShilpa/ods-ci
that referenced
this pull request
Nov 28, 2023
* Update nightlies install to V2 Signed-off-by: Luca Giorgi <[email protected]> * Hardcode NS variables for nightlies Signed-off-by: Luca Giorgi <[email protected]> * update dashboard check for nightlies Signed-off-by: Luca Giorgi <[email protected]> * Modify component checks Signed-off-by: Luca Giorgi <[email protected]> --------- Signed-off-by: Luca Giorgi <[email protected]>
ChughShilpa
pushed a commit
to ChughShilpa/ods-ci
that referenced
this pull request
Jan 2, 2024
* Update nightlies install to V2 Signed-off-by: Luca Giorgi <[email protected]> * Hardcode NS variables for nightlies Signed-off-by: Luca Giorgi <[email protected]> * update dashboard check for nightlies Signed-off-by: Luca Giorgi <[email protected]> * Modify component checks Signed-off-by: Luca Giorgi <[email protected]> --------- Signed-off-by: Luca Giorgi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.