Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump kfp-tekton to 1.5.8 #905

Merged
merged 3 commits into from
Sep 18, 2023
Merged

Bump kfp-tekton to 1.5.8 #905

merged 3 commits into from
Sep 18, 2023

Conversation

diegolovison
Copy link
Contributor

Bump kfp-tekton to 1.5.8

@diegolovison diegolovison added the needs testing Needs to be tested in Jenkins label Sep 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
359 0 0 359 100

@diegolovison diegolovison removed the needs testing Needs to be tested in Jenkins label Sep 5, 2023
@diegolovison
Copy link
Contributor Author

rhods-ci-pr-test/1993/TestReport/

jgarciao
jgarciao requested changes Sep 5, 2023
View reviewed changes
ods_ci/libs/DataSciencePipelinesAPI.py Show resolved Hide resolved
ods_ci/libs/DataSciencePipelinesAPI.py Outdated Show resolved Hide resolved
@bdattoma
Copy link
Contributor

bdattoma commented Sep 6, 2023

I see more changes rather than only bumping the kfp version. Are these changes caused by the library change? Could you please extend the PR name/description?

@diegolovison
Copy link
Contributor Author

I see more changes rather than only bumping the kfp version. Are these changes caused by the library change? Could you please extend the PR name/description?

all related

lugi0
lugi0 reviewed Sep 11, 2023
View reviewed changes
poetry.lock
@@ -1,4 +1,4 @@
# This file is automatically @generated by Poetry 1.6.1 and should not be changed by hand.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file might need to be recreated to include changes already made in master

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

bdattoma
bdattoma previously approved these changes Sep 18, 2023
View reviewed changes
@jgarciao
Copy link
Contributor

Diego, kfp_tekton 1.5.9 was released on Sep 12. Should we use that one instead?

@jgarciao jgarciao self-requested a review September 18, 2023 13:56
@jgarciao jgarciao added the enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) label Sep 18, 2023
@diegolovison
Copy link
Contributor Author

Diego, kfp_tekton 1.5.9 was released on Sep 12. Should we use that one instead?

next PR

@jgarciao jgarciao merged commit ee42eaa into red-hat-data-services:master Sep 18, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

ChughShilpa pushed a commit to ChughShilpa/ods-ci that referenced this pull request Nov 28, 2023
@diegolovison @jgarciao
Bump kfp-tekton to 1.5.8 (red-hat-data-services#905)
5bf983a 
* Bump kfp-tekton to 1.5.8

* Add time sleep back

---------

Co-authored-by: Jorge <[email protected]>
ChughShilpa pushed a commit to ChughShilpa/ods-ci that referenced this pull request Jan 2, 2024
@diegolovison @jgarciao
Bump kfp-tekton to 1.5.8 (red-hat-data-services#905)
ffcfa80 
* Bump kfp-tekton to 1.5.8

* Add time sleep back

---------

Co-authored-by: Jorge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lugi0 lugi0 lugi0 left review comments

@bdattoma bdattoma bdattoma approved these changes

@jgarciao jgarciao jgarciao approved these changes

Assignees
No one assigned
Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@diegolovison @bdattoma @jgarciao @lugi0