Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait 30 seconds to check if pods are equals to 0 when deleting pipeline server #895

Merged
merged 4 commits into from
Sep 1, 2023

Conversation

diegolovison
Copy link
Contributor

Greater than 30 seconds I would say we should investigate

Greater than 30 seconds I would say we should investigate
@diegolovison
Copy link
Contributor Author

Tested and it is working

1 test, 1 passed, 0 failed
==============================================================================
Tests.Ods Dashboard.Data Science Pipelines                            | PASS |
1 test, 1 passed, 0 failed
==============================================================================
Tests.Ods Dashboard                                                   | PASS |
1 test, 1 passed, 0 failed
==============================================================================
Tests                                                                 | PASS |
1 test, 1 passed, 0 failed
==============================================================================
Output:  /home/dlovison/github/openshift-data-science/ods-ci/ods_ci/test-output/ods-ci-2023-08-30-08-25-muaYB8t79r/output.xml
XUnit:   /home/dlovison/github/openshift-data-science/ods-ci/ods_ci/test-output/ods-ci-2023-08-30-08-25-muaYB8t79r/xunit_test_result.xml
Log:     /home/dlovison/github/openshift-data-science/ods-ci/ods_ci/test-output/ods-ci-2023-08-30-08-25-muaYB8t79r/log.html
Report:  /home/dlovison/github/openshift-data-science/ods-ci/ods_ci/test-output/ods-ci-2023-08-30-08-25-muaYB8t79r/test_report.html

@diegolovison diegolovison added the needs testing Needs to be tested in Jenkins label Aug 31, 2023
@@ -110,5 +110,9 @@
Click Element //li[contains(a/text(), 'Delete pipeline server')]
Handle Deletion Confirmation Modal ${data_science_project_name} pipeline server pipeline server
Wait Until Page Contains Element xpath://h2[contains(text(), 'No pipeline server')]
${pod_count} Run oc get pods -n ${data_science_project_name} | wc -l
FOR ${index} IN RANGE 0 30

Check notice

Code scanning / Robocop

Variable '{{ name }}' is assigned but not used

Variable '${index}' is assigned but not used
${pod_count} Run oc get pods -n ${data_science_project_name} | wc -l
FOR ${index} IN RANGE 0 30
${pod_count} Run oc get pods -n ${data_science_project_name} -l component=data-science-pipelines | wc -l
IF ${pod_count}==0 BREAK

Check notice

Code scanning / Robocop

'{{ block_name }}' condition can be simplified

'INLINE IF' condition can be simplified
@github-actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
355 0 0 355 100

@diegolovison
Copy link
Contributor Author

rhods-ci-pr-test/1989
Finished: SUCCESS

@diegolovison diegolovison removed the needs testing Needs to be tested in Jenkins label Aug 31, 2023
@jgarciao jgarciao changed the title Wait 30 seconds to check if pods are equals to 0 Wait 30 seconds to check if pods are equals to 0 when deleting pipeline server Aug 31, 2023
@jgarciao jgarciao added enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins labels Aug 31, 2023
@jgarciao jgarciao requested a review from lugi0 September 1, 2023 08:08
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jgarciao jgarciao merged commit 6c1df7a into master Sep 1, 2023
lugi0 pushed a commit to lugi0/ods-ci that referenced this pull request Sep 11, 2023
…ne server (red-hat-data-services#895)

* Wait 30 seconds to check if pods are equals to 0

Greater than 30 seconds I would say we should investigate

* Filter by dsp components

---------

Co-authored-by: Jorge <[email protected]>
@bdattoma bdattoma deleted the diegolovison-patch-3 branch May 29, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants