Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pyyaml to work ods-ci on macos #891

Merged
merged 4 commits into from
Aug 30, 2023
Merged

Update pyyaml to work ods-ci on macos #891

merged 4 commits into from
Aug 30, 2023

Conversation

kornys
Copy link
Contributor

@kornys kornys commented Aug 29, 2023

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2023 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
354 0 0 354 100

@jgarciao jgarciao self-requested a review August 30, 2023 09:28
@jgarciao jgarciao added the needs testing Needs to be tested in Jenkins label Aug 30, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

jgarciao
jgarciao approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@jgarciao jgarciao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you test it in jenkins before merging it?

@jgarciao jgarciao added the enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) label Aug 30, 2023
@kornys
Copy link
Contributor Author

kornys commented Aug 30, 2023

Can you test it in jenkins before merging it?

@jgarciao it was already tested with jenkins @bdattoma checked results and didn't see any problems caused by this.

@jgarciao jgarciao added verified This PR has been tested with Jenkins and removed needs testing Needs to be tested in Jenkins labels Aug 30, 2023
@jgarciao jgarciao merged commit 64b7844 into red-hat-data-services:master Aug 30, 2023
lugi0 pushed a commit to lugi0/ods-ci that referenced this pull request Sep 11, 2023
@kornys @jgarciao @lugi0
Update pyyaml to work ods-ci on macos (red-hat-data-services#891)
c3fa13a 
Co-authored-by: Jorge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgarciao jgarciao jgarciao approved these changes

@bdattoma bdattoma bdattoma approved these changes

Assignees
No one assigned
Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kornys @jgarciao @bdattoma