Add tests for deploying models with multiple replicas #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Robocop found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
bdattoma
requested review from
tarukumar,
lugi0,
jgarciao,
diegolovison and
manosnoam
bdattoma
added
needs testing
bdattoma
force-pushed
the
f/watsonx-4
branch
2 times, most recently
from
2afe216 to
f2a2b54
Compare
bdattoma
added
verified
|
locally verified, Jenkins still not able to run these tests for a missing pkg. Will try to send a PR for jenkins later in the week |
Signed-off-by: bdattoma <[email protected]>
Signed-off-by: bdattoma <[email protected]>
Signed-off-by: bdattoma <[email protected]>
Signed-off-by: bdattoma <[email protected]>
Signed-off-by: bdattoma <[email protected]>
Signed-off-by: bdattoma <[email protected]>
Signed-off-by: bdattoma <[email protected]>
Signed-off-by: bdattoma <[email protected]>
Signed-off-by: bdattoma <[email protected]>
Signed-off-by: bdattoma <[email protected]>
Signed-off-by: bdattoma <[email protected]>
Signed-off-by: bdattoma <[email protected]>
Signed-off-by: bdattoma <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
tarukumar
approved these changes
Aug 29, 2023
jgarciao
approved these changes
Aug 29, 2023
lugi0
pushed a commit
to lugi0/ods-ci
that referenced
this pull request
Sep 11, 2023
…ervices#885) * fix ksvc expected name Signed-off-by: bdattoma <[email protected]> * add json file with expected answers Signed-off-by: bdattoma <[email protected]> * update predictor obj name after latest prod change Signed-off-by: bdattoma <[email protected]> * add missing response check ODS-2341 Signed-off-by: bdattoma <[email protected]> * add min replicas number Signed-off-by: bdattoma <[email protected]> * replace s3 path with variables Signed-off-by: bdattoma <[email protected]> * add replicas check + skip pre-reqs Signed-off-by: bdattoma <[email protected]> * remove redundant secret creation Signed-off-by: bdattoma <[email protected]> * add kw to delete isvc Signed-off-by: bdattoma <[email protected]> * replace bucket info with test-variables Signed-off-by: bdattoma <[email protected]> * move model dir to variable + fix endpoint Signed-off-by: bdattoma <[email protected]> * add multiple scaling and query check Signed-off-by: bdattoma <[email protected]> * add polarion id + rename tc Signed-off-by: bdattoma <[email protected]> --------- Signed-off-by: bdattoma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding automation for ODS-2376 and applying bucket variables