Add fixes for Jupyter oauth caching and workbenches xpaths #871
Conversation
Signed-off-by: Luca Giorgi <[email protected]>
lugi0
added
needs testing
Signed-off-by: Luca Giorgi <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -288,7 +288,7 @@ Spawn Notebook With Arguments # robocop: disable | |||
| END | |||
| END | |||
| Spawn Notebook ${spawner_timeout} ${same_tab} | |||
| Run Keyword And Continue On Failure Wait Until Page Contains Log in with OpenShift timeout=15s | |||
| Run Keyword And Warn On Failure Wait Until Page Contains Log in with OpenShift timeout=15s | |||
There was a problem hiding this comment.
Why Run Keyword And Warn On Failure?
Didn't understand why the element can be or not there
There was a problem hiding this comment.
In a single user session it will only appear the first time the user tries to access a notebook/workbench, and after that it's cached.
The wait is still important otherwise the following keyword could miss the actual oauth login page, but we don't want to raise a failure in case it does not appear due to caching
There was a problem hiding this comment.
I approved. Curious, why not handle that into the Log in with OpenShift?
No description provided.