post upgrade starting version check for Model Registry #2044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lugi0 <[email protected]>
Signed-off-by: lugi0 <[email protected]>
lugi0
added
the
enhancements
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -248,6 +248,8 @@ | |||
| [Documentation] Verifies that registered model/version in pre-upgrade is present after the upgrade | |||
| [Tags] Upgrade ModelRegistryUpgrade | |||
| ... ProductBug RHOAIENG-15033 | |||
| ${check}= Is Starting Version Supported minimum_version=2.14.0 | |||
Check warning
Code scanning / Robocop
The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test
| @@ -248,6 +248,8 @@ | |||
| [Documentation] Verifies that registered model/version in pre-upgrade is present after the upgrade | |||
| [Tags] Upgrade ModelRegistryUpgrade | |||
| ... ProductBug RHOAIENG-15033 | |||
| ${check}= Is Starting Version Supported minimum_version=2.14.0 | |||
| Skip If ${check}==${FALSE} | |||
Check notice
Code scanning / Robocop
'{{ block_name }}' condition can be simplified Note test
Robot Results
|
kobihk
reviewed
Nov 18, 2024
ods_ci/tests/Tests/0200__rhoai_upgrade/0203__post_upgrade.robot
Outdated
Show resolved
Hide resolved
Signed-off-by: lugi0 <[email protected]>
|
FedeAlonso
approved these changes
Nov 18, 2024
kobihk
approved these changes
Nov 18, 2024
lenahorsley
pushed a commit
to lenahorsley/ods-ci
that referenced
this pull request
Nov 18, 2024
…services#2044) * Add check on starting version in post upgrade test Signed-off-by: lugi0 <[email protected]> * update post upgrade test tag Signed-off-by: lugi0 <[email protected]> * Move new keywords to Common Signed-off-by: lugi0 <[email protected]> --------- Signed-off-by: lugi0 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.