Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Dashboard related model serving issues #2022

Conversation

FedeAlonso
Copy link
Contributor

https://issues.redhat.com/browse/RHOAIENG-15722
There was a couple issues:

  • Dropdown are disabled if there's only one option
  • New way of getting the inference endpoint

During the fix, there was another issue with navigation which was introduced #1933, that's why I'm deleting the "Menu.Navigate to page" as it was only working always ok with DSP related tests.

A model Serving execution:
Screenshot from 2024-11-12 15-50-21

Also, in order to check that the DSP tests where working, I ran an Smoke of the 0410:

Screenshot from 2024-11-12 16-41-08

@FedeAlonso FedeAlonso added the verified This PR has been tested with Jenkins label Nov 12, 2024
... Element Should Be Enabled xpath://button[@id="inference-service-data-connection"]

IF ${is_enabled}
FOR ${retry_idx} IN RANGE 0 1+${retries}

Check notice

Code scanning / Robocop

Variable '{{ name }}' is assigned but not used Note test

Variable '${retry_idx}' is assigned but not used
${url}= SeleniumLibrary.Get Element Attribute ${route_xpath} value
${kserve}= Run Keyword And Return Status SeleniumLibrary.Page Should Contain Single-model serving enabled
# Click on Inference Endpoints link
${endpoint_link}= Set Variable //a[@data-testid="metrics-link-test-model" and text()="${model_name}"]/ancestor::tr//td//button[@data-testid="internal-external-service-button"]

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (185/120)
SeleniumLibrary.Wait Until Page Contains Element ${endpoint_link}
SeleniumLibrary.Click Button ${endpoint_link}
# Get the external URL
${route_xpath}= Set Variable //span[text()="External (can be accessed from inside or outside the cluster)"]/ancestor::dl//dd/div/div/span[1]

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (150/120)
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
566 0 0 566 100

Click Element xpath://li/button[.="${data_connection_name}"]
${selected}= Run Keyword And Return Status
... Page Should Contain Element //span[.="Name"]/../../..//button[@aria-label="Options menu"][.="${data_connection_name}"] #robocop: disable
IF ${selected}==${TRUE} BREAK

Check notice

Code scanning / Robocop

'{{ block_name }}' condition can be simplified Note test

'INLINE IF' condition can be simplified
@FedeAlonso FedeAlonso merged commit 823465d into red-hat-data-services:master Nov 12, 2024
8 checks passed
lenahorsley pushed a commit to lenahorsley/ods-ci that referenced this pull request Nov 18, 2024
* fix: ODS-2206, wrong pipelines xpath

* fix model serving issues

* fix wrong xpath
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verified This PR has been tested with Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants