-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Dashboard related model serving issues #2022
Fix: Dashboard related model serving issues #2022
Conversation
... Element Should Be Enabled xpath://button[@id="inference-service-data-connection"] | ||
|
||
IF ${is_enabled} | ||
FOR ${retry_idx} IN RANGE 0 1+${retries} |
Check notice
Code scanning / Robocop
Variable '{{ name }}' is assigned but not used Note test
${url}= SeleniumLibrary.Get Element Attribute ${route_xpath} value | ||
${kserve}= Run Keyword And Return Status SeleniumLibrary.Page Should Contain Single-model serving enabled | ||
# Click on Inference Endpoints link | ||
${endpoint_link}= Set Variable //a[@data-testid="metrics-link-test-model" and text()="${model_name}"]/ancestor::tr//td//button[@data-testid="internal-external-service-button"] |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
SeleniumLibrary.Wait Until Page Contains Element ${endpoint_link} | ||
SeleniumLibrary.Click Button ${endpoint_link} | ||
# Get the external URL | ||
${route_xpath}= Set Variable //span[text()="External (can be accessed from inside or outside the cluster)"]/ancestor::dl//dd/div/div/span[1] |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
Robot Results
|
Click Element xpath://li/button[.="${data_connection_name}"] | ||
${selected}= Run Keyword And Return Status | ||
... Page Should Contain Element //span[.="Name"]/../../..//button[@aria-label="Options menu"][.="${data_connection_name}"] #robocop: disable | ||
IF ${selected}==${TRUE} BREAK |
Check notice
Code scanning / Robocop
'{{ block_name }}' condition can be simplified Note test
Quality Gate passedIssues Measures |
* fix: ODS-2206, wrong pipelines xpath * fix model serving issues * fix wrong xpath
https://issues.redhat.com/browse/RHOAIENG-15722
There was a couple issues:
During the fix, there was another issue with navigation which was introduced #1933, that's why I'm deleting the "Menu.Navigate to page" as it was only working always ok with DSP related tests.
A model Serving execution:
Also, in order to check that the DSP tests where working, I ran an Smoke of the 0410: