Fix some single model dashboard issues #2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rnetser
commented
Nov 12, 2024
rnetser
commented
- Click "Select single-model" only if no models
- fix runtime selection
rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
FedeAlonso
approved these changes
Nov 12, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -446,9 +447,13 @@ | |||
| [Arguments] ${model_name} ${serving_runtime} ${data_connection} ${path} | |||
| ... ${model_framework}=caikit ${replicas}=1 ${size}=Small ${no_gpus}=${0} | |||
| ... ${token}=${FALSE} ${multi_token}=${FALSE} ${multi_service_account_name}=default-name2 | |||
| ... ${public_endpoint}=${TRUE} ${service_account_name}=${NONE} | |||
| ... ${public_endpoint}=${TRUE} ${service_account_name}=${NONE} ${existing_server}=${FALSE} | |||
Check notice
Code scanning / Robocop
There is too many arguments per continuation line ({{ arguments_count }} / {{ max_arguments_count }}) Note test
| Move To Tab Models | ||
| SeleniumLibrary.Click Button ${DEPLOY_SINGLE_SV_MODEL_BTN} | ||
| IF ${existing_server} == False |
Check notice
Code scanning / Robocop
'{{ block_name }}' condition can be simplified Note test
Robot Results
|
asanzgom
approved these changes
Nov 12, 2024
lenahorsley
pushed a commit
to lenahorsley/ods-ci
that referenced
this pull request
Nov 18, 2024
* fix single rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED * fix server selection rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.