Add wait for deployment ready #1996
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Suite Setup Suite Setup | ||
| Suite Teardown Suite Teardown | ||
|
|
||
|
|
||
| *** Variables *** | ||
| ${APPLICATIONS_NS} ${APPLICATIONS_NAMESPACE} |
Check notice
Code scanning / Robocop
Variable '{{ name }}' is assigned but not used Note test
| ${TRAINING_LABEL_SELECTOR} app.kubernetes.io/name=training-operator | ||
| ${DATASCIENCEPIPELINES_LABEL_SELECTOR} app.kubernetes.io/name=data-science-pipelines-operator | ||
| ${MODELMESH_CONTROLLER_LABEL_SELECTOR} app.kubernetes.io/instance=modelmesh-controller | ||
| ${ODH_MODEL_CONTROLLER_LABEL_SELECTOR} app=odh-model-controller |
Check notice
Code scanning / Robocop
Variable '{{ name }}' is assigned but not used Note test
| ${MODELMESH_CONTROLLER_LABEL_SELECTOR} app.kubernetes.io/instance=modelmesh-controller | ||
| ${ODH_MODEL_CONTROLLER_LABEL_SELECTOR} app=odh-model-controller | ||
| ${MODELREGISTRY_CONTROLLER_LABEL_SELECTOR} control-plane=model-registry-operator | ||
| ${KSERVE_CONTROLLER_MANAGER_LABEL_SELECTOR} control-plane=kserve-controller-manager |
Check notice
Code scanning / Robocop
Variable '{{ name }}' is assigned but not used Note test
| modelmeshserving modelmesh-controller odh_modelmesh_controller_image | ||
| datasciencepipelines data-science-pipelines-operator-controller-manager odh_data_science_pipelines_operator_controller_image | ||
| trainingoperator kubeflow-training-operator odh_training_operator_image | ||
| codeflare codeflare-operator-manager ${CODEFLARE_LABEL_SELECTOR} odh_codeflare_operator_image |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
| modelmeshserving modelmesh-controller odh_modelmesh_controller_image | ||
| datasciencepipelines data-science-pipelines-operator-controller-manager odh_data_science_pipelines_operator_controller_image | ||
| trainingoperator kubeflow-training-operator odh_training_operator_image | ||
| codeflare codeflare-operator-manager ${CODEFLARE_LABEL_SELECTOR} odh_codeflare_operator_image |
Check warning
Code scanning / Robocop
Trailing whitespace at the end of line Warning test
| kueue kueue-controller-manager ${KUEUE_LABEL_SELECTOR} odh_kueue_controller_image | ||
| workbenches odh-notebook-controller-manager ${WORKBENCHES_LABEL_SELECTOR} odh_notebook_controller_image | ||
| workbenches notebook-controller-deployment ${WORKBENCHES_LABEL_SELECTOR} odh_kf_notebook_controller_image | ||
| dashboard ${DASHBOARD_DEPLOYMENT_NAME} ${DASHBOARD_LABEL_SELECTOR} odh_dashboard_image |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
| kueue kueue-controller-manager ${KUEUE_LABEL_SELECTOR} odh_kueue_controller_image | ||
| workbenches odh-notebook-controller-manager ${WORKBENCHES_LABEL_SELECTOR} odh_notebook_controller_image | ||
| workbenches notebook-controller-deployment ${WORKBENCHES_LABEL_SELECTOR} odh_kf_notebook_controller_image | ||
| dashboard ${DASHBOARD_DEPLOYMENT_NAME} ${DASHBOARD_LABEL_SELECTOR} odh_dashboard_image |
Check warning
Code scanning / Robocop
Trailing whitespace at the end of line Warning test
| workbenches odh-notebook-controller-manager ${WORKBENCHES_LABEL_SELECTOR} odh_notebook_controller_image | ||
| workbenches notebook-controller-deployment ${WORKBENCHES_LABEL_SELECTOR} odh_kf_notebook_controller_image | ||
| dashboard ${DASHBOARD_DEPLOYMENT_NAME} ${DASHBOARD_LABEL_SELECTOR} odh_dashboard_image | ||
| modelmeshserving modelmesh-controller ${MODELMESH_CONTROLLER_LABEL_SELECTOR} odh_modelmesh_controller_image |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
| workbenches notebook-controller-deployment ${WORKBENCHES_LABEL_SELECTOR} odh_kf_notebook_controller_image | ||
| dashboard ${DASHBOARD_DEPLOYMENT_NAME} ${DASHBOARD_LABEL_SELECTOR} odh_dashboard_image | ||
| modelmeshserving modelmesh-controller ${MODELMESH_CONTROLLER_LABEL_SELECTOR} odh_modelmesh_controller_image | ||
| datasciencepipelines data-science-pipelines-operator-controller-manager ${DATASCIENCEPIPELINES_LABEL_SELECTOR} odh_data_science_pipelines_operator_controller_image |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
| dashboard ${DASHBOARD_DEPLOYMENT_NAME} ${DASHBOARD_LABEL_SELECTOR} odh_dashboard_image | ||
| modelmeshserving modelmesh-controller ${MODELMESH_CONTROLLER_LABEL_SELECTOR} odh_modelmesh_controller_image | ||
| datasciencepipelines data-science-pipelines-operator-controller-manager ${DATASCIENCEPIPELINES_LABEL_SELECTOR} odh_data_science_pipelines_operator_controller_image | ||
| trainingoperator kubeflow-training-operator ${TRAINING_LABEL_SELECTOR} odh_training_operator_image |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
Robot Results
|
|
Running rhods-ci-pr-test/3423/ together with all Operator Test Cases |
...100__platform/0101__deploy/0104__operators/0104__rhods_operator/0114__component_images.robot
Show resolved
Hide resolved
|
rhods-ci-pr-test/3423/ passed successfully |
|
jgarciao
dismissed
their stale review
My proposal could be done in a follow-up PR
Added check for deployment ready since execution together with other Test Cases that remove model mesh deployment can cause the recreation of deployment to not be ready at the moment of execution