Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-11849 Refactor is required for edit DSP form #1964

Merged
merged 1 commit into from
Oct 30, 2024
Merged

RHOAIENG-11849 Refactor is required for edit DSP form #1964

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/Projects.resource
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,8 +456,7 @@ Check Resource Name Should Be Immutable
[Documentation] Checks if the Resource Name is not editable
[Arguments] ${project_title}
ODHDashboard.Click Action From Actions Menu item_title=${project_title} item_type=project action=Edit
Wait Until Page Contains Element ${RESOURCE_INPUT_XP}
Element Should Be Disabled ${RESOURCE_INPUT_XP}
Page Should Not Contain Element ${RESOURCE_INPUT_XP}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see the Resource name title and an immutable field below it. So, shouldn't we update the xpath of the RESOURCE_INPUT_XP? Otherwise this check doesn't make sense. What am I missing?
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the xpath for ${RESOURCE_INPUT_XP} is used for creating a project test, and the changes for ODS-2112 test is to check that its not there when editing a project. WYT ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, got it. Since we were testing presence of the Element before, I would expect that apart from this Should Not Contain Element, we would also have another Should Contain Element with the xpath to the expected field that is there now.

But I'm not gonna block this.

Click Button Cancel

Update Data Science Project Name
Expand Down
Loading