Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-14857 Update the test to implement data-testids #1954

Merged

Conversation

ConorOM1
Copy link
Contributor

@ConorOM1 ConorOM1 commented Oct 22, 2024

This fixes UI failures for ODS-2276. The test is updated to use the data-testids

Tested on : devops/job/rhoai-test-flow/961/

image

Copy link

Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
546 0 0 546 100

@jstourac
Copy link
Member

Has this been verified? Some labels would be nice - this should have enhancement and once the change is verified on Jenkins or with some decent run, it should have also verified label. Ideally put a link to a Jenkins run (link stub only) or a screenshot with the passed tests.

@ConorOM1 ConorOM1 added the enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) label Oct 22, 2024
@ConorOM1 ConorOM1 added the verified This PR has been tested with Jenkins label Oct 22, 2024
@ConorOM1
Copy link
Contributor Author

Has this been verified? Some labels would be nice - this should have enhancement and once the change is verified on Jenkins or with some decent run, it should have also verified label. Ideally put a link to a Jenkins run (link stub only) or a screenshot with the passed tests.

Thanks for reviewing. Additional information added

@FedeAlonso FedeAlonso merged commit b1c0b1a into red-hat-data-services:master Oct 23, 2024
8 checks passed
tonyxrmdavidson pushed a commit to tonyxrmdavidson/ods-ci that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants