Only upload the openshift CA cert if the cluster is self-managed in MR test #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lugi0 <[email protected]>
lugi0
added
the
enhancements
|
jgarciao
approved these changes
Oct 17, 2024
Robot Results
|
tarukumar
approved these changes
Oct 17, 2024
lugi0
added a commit
that referenced
this pull request
Oct 17, 2024
Signed-off-by: lugi0 <[email protected]>
lugi0
added a commit
that referenced
this pull request
Oct 28, 2024
Signed-off-by: lugi0 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We fetch the openshift CA cert only if the cluster is self managed, but then try to upload it regardless of cluster type (L#113).
Use the same check on the upload step to avoid trying to upload a non existing file.