fix for single serving test #1934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/ModelServer.resource
Dismissed
Show dismissed
Hide dismissed
Robot Results
|
jstourac
reviewed
Oct 16, 2024
| @@ -19,13 +19,14 @@ ${S3_REGION_DC_INPUT_XP}= xpath=//input[@aria-label="Field list AWS_DEF | |||
| ${S3_BUCKET_DC_INPUT_XP}= xpath=//input[@aria-label="Field list AWS_S3_BUCKET"] | |||
| ${S3_DEFAULT_BUCKET}= ods-ci-s3 | |||
| ${MS_TABLE_PROJECT}= /../../td[@data-label="Project"] | |||
| ${MS_TABLE_ENDPOINT_INPUT}= /ancestor::tr//td[@data-label="Inference endpoint"]//button[@data-testid='internal-service-button'] | |||
| ${MS_TABLE_ENDPOINT_INPUT}= /ancestor::tr//td[@data-label="Inference endpoint"]//button[@id='copy-button-4'] | |||
There was a problem hiding this comment.
Hm, interesting - truly moving away from the data-testid to a simple id? Was it removed from the element so we can't use it anymore?
There was a problem hiding this comment.
yeah there is only a data-testid for the internal endpoint option at the moment. If the external route option is enabled there is no data-testid
lugi0
approved these changes
Oct 17, 2024
FedeAlonso
approved these changes
Oct 17, 2024
CFSNM
approved these changes
Oct 17, 2024
manosnoam
pushed a commit
to manosnoam/ods-ci
that referenced
this pull request
Oct 30, 2024
This is to add UI fixes for ODS-2626 & ODS-2552. Previous test updates were for multi-model scenario, the original UI bugs were in the single model server test. Signed-off-by: manosnoam <[email protected]>
manosnoam
added a commit
that referenced
this pull request
Oct 31, 2024
Backport PR #1934 to branch 2.14: Fix for single serving test This is to add UI fixes for ODS-2626 & ODS-2552. Previous test updates were for multi-model scenario, the original UI bugs were in the single model server test. Signed-off-by: manosnoam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to add UI fixes for ODS-2626 & ODS-2552. Previous test updates were for multi-model scenario, the original UI bugs were in the single model server test.