Fix user permission tests #1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstourac
added
the
enhancements
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| [Documentation] Creates a custom group using oc cli command | ||
| [Arguments] ${group_name} | ||
| ${group_created}= Run Keyword And Return Status Create Group group_name=${group_name} | ||
| IF ${group_created} == False |
Check notice
Code scanning / Robocop
'{{ block_name }}' condition can be simplified Note test
ods_ci/tests/Tests/0500__ide/0501__ide_jupyterhub/jupyterhub-user-access.robot
Fixed
Show fixed
Hide fixed
Robot Results
|
* fixes the failing test caued by recent changes in the ODHDashboard resource which we use for the dashboard page loading * minor refactoring of the code and some comments added for easier understandability of the test steps
For some dashboard pages, it takes time to load properly and they can change the content during that time. E.g. there is a "Loading" text with an animated gif provided until the actual page is present. In case of accessing the Applications -> Enabled -> Jupyter app tile, there may be also present a page title with "Loading..." text for a brief amount of time. Such thing breaks our detection technique as then our expected page title text doesn't match with what was present on the page and fails with: ``` BuiltIn.Should Be Equal: Loading... != Start a notebook server ``` Adding a couple of retries should help to avoid such situation.
jstourac
force-pushed
the
fixUserPermissionTests
branch
from
d30d894 to
ade2e8c
Compare
|
lugi0
reviewed
Oct 10, 2024
lugi0
approved these changes
Oct 10, 2024
jiridanek
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resource which we use for the dashboard page loading
understandability of the test steps
For some dashboard pages, it takes time to load properly and they can
change the content during that time. E.g. there is a "Loading" text with
an animated gif provided until the actual page is present.
In case of accessing the Applications -> Enabled -> Jupyter app tile,
there may be also present a page title with "Loading..." text for a
brief amount of time. Such thing breaks our detection technique as then
our expected page title text doesn't match with what was present on the
page and fails with:
CI:
